Bug 95640 – [EFL] Add missing semicolon at the end of some lines.

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit EFL

[Byungwoo Lee]

In the ewk_view.cpp, there are some lines that doesn't have semicolon,
but there was no build error about this.

This is caused by some macro definition in the file.

[Byungwoo Lee]

Created attachment 161827 [details]
Patch

[Byungwoo Lee]

Created attachment 161828 [details]
Patch

[Byungwoo Lee]

Fixed typo in Changelog.

[Chris Dumez]

Comment on attachment 161828 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=161828&action=review

On principal, I like the idea.

> Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:168
> +    } while (0)

We don't technically need to do { } while(0) here. Why not simply get rid of the semicolon at the end of evas_object_smart_data_get(ewkView)?

[Raphael Kubo da Costa (:rakuco)]

Comment on attachment 161828 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=161828&action=review

EWK_VIEW_TYPE_CHECK does not seem to have had any meaningful change, I don't understand the reason for the additional spaces at the end of the lines.

>> Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:168
>> +    } while (0)
> 
> We don't technically need to do { } while(0) here. Why not simply get rid of the semicolon at the end of evas_object_smart_data_get(ewkView)?

The best reason I can think of is convention.

[Byungwoo Lee]

(In reply to comment #5)

> EWK_VIEW_TYPE_CHECK does not seem to have had any meaningful change, I don't understand the reason for the additional spaces at the end of the lines.
It was because that all the position of the '\' were fitted in the previous code.

> 
> >> Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:168
> >> +    } while (0)
> > 
> > We don't technically need to do { } while(0) here. Why not simply get rid of the semicolon at the end of evas_object_smart_data_get(ewkView)?
> 
> The best reason I can think of is convention.
Yes, I just add the while (0), but I think removing semicolon will be easier for the line. And with this additional fitting for '\' also not required.

I'll change those. Thanks :)

[Byungwoo Lee]

Created attachment 161835 [details]
Patch

[Chris Dumez]

Comment on attachment 161835 [details]
Patch

LGTM.

[Raphael Kubo da Costa (:rakuco)]

Comment on attachment 161835 [details]
Patch

Looks good, thank you.

[WebKit Review Bot]

Comment on attachment 161835 [details]
Patch

Clearing flags on attachment: 161835

Committed r127390: <http://trac.webkit.org/changeset/127390>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.