Bug 95626 - Elide test names when running new-run-webkit-tests
Summary: Elide test names when running new-run-webkit-tests
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tony Chang
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-08-31 17:01 PDT by Tony Chang
Modified: 2012-09-04 12:11 PDT (History)
4 users (show)

See Also:


Attachments
Patch (8.79 KB, patch)
2012-08-31 17:05 PDT, Tony Chang
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tony Chang 2012-08-31 17:01:41 PDT
Elide test names when running new-run-webkit-tests
Comment 1 Tony Chang 2012-08-31 17:05:28 PDT
Created attachment 161793 [details]
Patch
Comment 2 Tony Chang 2012-08-31 17:11:33 PDT
You can see the jankiness if you run layout tests with an 80 col wide terminal.
Comment 3 Tony Chang 2012-08-31 17:13:23 PDT
BTW, I intentionally didn't implement on Windows python, but it looks like it should be possible:
http://code.google.com/p/python-progressbar/issues/detail?id=12
Comment 4 Dirk Pranke 2012-08-31 17:57:09 PDT
Comment on attachment 161793 [details]
Patch

looks reasonable, the previous output works fine on at least some platforms, I think (or at least it used to). What platforms / TERM settings are you seeing issues on?
Comment 5 Tony Chang 2012-08-31 18:08:27 PDT
On Linux, if the test is longer than the line, it leaves the text and scrolls by.
Comment 6 Dirk Pranke 2012-08-31 20:07:43 PDT
(In reply to comment #5)
> On Linux, if the test is longer than the line, it leaves the text and scrolls by.

Hm. ssh'ed in from my mac (Terminal running ssh, TERM=xterm256color), it mostly works (although I have seen it get out of sync in some cases; that's probably a separate bug). Perhaps it's your terminal emulator that has a problem?

That said, I think the change is good, don't get me wrong ...
Comment 7 Tony Chang 2012-09-04 11:26:24 PDT
Comment on attachment 161793 [details]
Patch

You probably need to run it from a Linux terminal to see the problem.
Comment 8 WebKit Review Bot 2012-09-04 11:45:11 PDT
Comment on attachment 161793 [details]
Patch

Clearing flags on attachment: 161793

Committed r127478: <http://trac.webkit.org/changeset/127478>
Comment 9 WebKit Review Bot 2012-09-04 11:45:14 PDT
All reviewed patches have been landed.  Closing bug.
Comment 10 Ojan Vafai 2012-09-04 12:11:12 PDT
Committed r127482: <http://trac.webkit.org/changeset/127482>