WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
95626
Elide test names when running new-run-webkit-tests
https://bugs.webkit.org/show_bug.cgi?id=95626
Summary
Elide test names when running new-run-webkit-tests
Tony Chang
Reported
2012-08-31 17:01:41 PDT
Elide test names when running new-run-webkit-tests
Attachments
Patch
(8.79 KB, patch)
2012-08-31 17:05 PDT
,
Tony Chang
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Tony Chang
Comment 1
2012-08-31 17:05:28 PDT
Created
attachment 161793
[details]
Patch
Tony Chang
Comment 2
2012-08-31 17:11:33 PDT
You can see the jankiness if you run layout tests with an 80 col wide terminal.
Tony Chang
Comment 3
2012-08-31 17:13:23 PDT
BTW, I intentionally didn't implement on Windows python, but it looks like it should be possible:
http://code.google.com/p/python-progressbar/issues/detail?id=12
Dirk Pranke
Comment 4
2012-08-31 17:57:09 PDT
Comment on
attachment 161793
[details]
Patch looks reasonable, the previous output works fine on at least some platforms, I think (or at least it used to). What platforms / TERM settings are you seeing issues on?
Tony Chang
Comment 5
2012-08-31 18:08:27 PDT
On Linux, if the test is longer than the line, it leaves the text and scrolls by.
Dirk Pranke
Comment 6
2012-08-31 20:07:43 PDT
(In reply to
comment #5
)
> On Linux, if the test is longer than the line, it leaves the text and scrolls by.
Hm. ssh'ed in from my mac (Terminal running ssh, TERM=xterm256color), it mostly works (although I have seen it get out of sync in some cases; that's probably a separate bug). Perhaps it's your terminal emulator that has a problem? That said, I think the change is good, don't get me wrong ...
Tony Chang
Comment 7
2012-09-04 11:26:24 PDT
Comment on
attachment 161793
[details]
Patch You probably need to run it from a Linux terminal to see the problem.
WebKit Review Bot
Comment 8
2012-09-04 11:45:11 PDT
Comment on
attachment 161793
[details]
Patch Clearing flags on attachment: 161793 Committed
r127478
: <
http://trac.webkit.org/changeset/127478
>
WebKit Review Bot
Comment 9
2012-09-04 11:45:14 PDT
All reviewed patches have been landed. Closing bug.
Ojan Vafai
Comment 10
2012-09-04 12:11:12 PDT
Committed
r127482
: <
http://trac.webkit.org/changeset/127482
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug