Bug 95610 - JSC bindings appear to sometimes ignore the possibility of arrays being in sparse mode
Summary: JSC bindings appear to sometimes ignore the possibility of arrays being in sp...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2012-08-31 14:21 PDT by Filip Pizlo
Modified: 2012-09-25 16:42 PDT (History)
7 users (show)

See Also:

Attachments
the pathc (11.51 KB, patch)
2012-09-25 14:35 PDT, Filip Pizlo 		oliver: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2012-08-31 14:21:19 PDT 
I'm not sure entirely what to do about this yet, or if it is even a bug.
Comment 1 Oliver Hunt 2012-08-31 16:17:49 PDT 
<rdar://problem/12219385>
Comment 2 Filip Pizlo 2012-09-25 14:35:56 PDT 
Created attachment 165676 [details]
the pathc
Comment 3 Oliver Hunt 2012-09-25 14:38:23 PDT 
Comment on attachment 165676 [details]
the pathc

View in context: https://bugs.webkit.org/attachment.cgi?id=165676&action=review

> Source/WebCore/bindings/js/JSInspectorFrontendHostCustom.cpp:92
>          // FIXME: What if the array is in sparse mode? https://bugs.webkit.org/show_bug.cgi?id=95610

this can go

> Source/WebCore/bindings/js/JSWebSocketCustom.cpp:77
>                  // FIXME: What if the array is in sparse mode? https://bugs.webkit.org/show_bug.cgi?id=95610

and this
Comment 4 Filip Pizlo 2012-09-25 16:42:47 PDT 
Landed in http://trac.webkit.org/changeset/129574