Bug 95597 - Unskip plugins/npruntime/delete-plugin-within-* tests on Windows
Summary: Unskip plugins/npruntime/delete-plugin-within-* tests on Windows
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: Plug-ins (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Hahnenberg
URL:
Keywords:
Depends on: 95624
Blocks:
  Show dependency tree / graph
 
Reported: 2012-08-31 11:57 PDT by Mark Hahnenberg
Modified: 2022-07-01 11:36 PDT (History)
3 users (show)

See Also:

Attachments
Patch (1.51 KB, patch)
2012-08-31 11:58 PDT, Mark Hahnenberg 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Hahnenberg 2012-08-31 11:57:41 PDT 
I believe the fix in bug 95394 should have fixed this in WK2 tests for Windows, so we should unskip them!
Comment 1 Mark Hahnenberg 2012-08-31 11:58:52 PDT 
Created attachment 161746 [details]
Patch
Comment 2 WebKit Review Bot 2012-08-31 13:31:52 PDT 
Comment on attachment 161746 [details]
Patch

Clearing flags on attachment: 161746

Committed r127309: <http://trac.webkit.org/changeset/127309>
Comment 3 WebKit Review Bot 2012-08-31 13:31:55 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 4 Roger Fong 2012-08-31 15:01:40 PDT 
plugins/npruntime/delete-plugin-within-hasProperty-return-false.html: 
plugins/npruntime/delete-plugin-within-hasProperty-return-true.html: 
plugins/npruntime/delete-plugin-within-setProperty.html: 
plugins/npruntime/delete-plugin-within-getProperty.html

Still broken on Windows sorry

You can find the results here:
http://build.webkit.org/results/Apple%20Win%207%20Release%20(Tests)/r127312%20(27161)/results.html
Comment 5 Mark Hahnenberg 2012-08-31 16:34:01 PDT 
(In reply to comment #4)
> plugins/npruntime/delete-plugin-within-hasProperty-return-false.html: 
> plugins/npruntime/delete-plugin-within-hasProperty-return-true.html: 
> plugins/npruntime/delete-plugin-within-setProperty.html: 
> plugins/npruntime/delete-plugin-within-getProperty.html
> 
> Still broken on Windows sorry

Okay, thought I had a fix but it turned out to be a regression on other stuff, so let's roll this sucker out.
Comment 6 WebKit Review Bot 2012-08-31 16:36:51 PDT 
Re-opened since this is blocked by 95624
Comment 7 Alexey Proskuryakov 2022-07-01 11:36:02 PDT 
Mass closing plug-in bugs, as plug-in support has been removed from WebKit.

Please comment and/or reopen if this still affects WebKit in some way.