Bug 95595 - Make computeBlockDirectionMargins const
Summary: Make computeBlockDirectionMargins const
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tony Chang
URL:
Keywords:
Depends on:
Blocks: 94982
  Show dependency tree / graph
 
Reported: 2012-08-31 11:26 PDT by Tony Chang
Modified: 2012-08-31 17:59 PDT (History)
4 users (show)

See Also:

Attachments
Patch (9.84 KB, patch)
2012-08-31 11:31 PDT, Tony Chang 		no flags Details | Formatted Diff | Diff
Patch for landing (9.80 KB, patch)
2012-08-31 14:41 PDT, Tony Chang 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tony Chang 2012-08-31 11:26:06 PDT 
Make computeBlockDirectionMargins const
Comment 1 Tony Chang 2012-08-31 11:31:16 PDT 
Created attachment 161742 [details]
Patch
Comment 2 Ojan Vafai 2012-08-31 12:28:05 PDT 
Comment on attachment 161742 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=161742&action=review

> Source/WebCore/rendering/RenderBox.cpp:2415
> +    computeBlockDirectionMargins(containingBlock,
> +        marginBefore, marginAfter);

Meh to wrapping this.
Comment 3 Tony Chang 2012-08-31 14:41:20 PDT 
Created attachment 161778 [details]
Patch for landing
Comment 4 WebKit Review Bot 2012-08-31 17:59:46 PDT 
Comment on attachment 161778 [details]
Patch for landing

Clearing flags on attachment: 161778

Committed r127346: <http://trac.webkit.org/changeset/127346>
Comment 5 WebKit Review Bot 2012-08-31 17:59:50 PDT 
All reviewed patches have been landed.  Closing bug.