Bug 95590 – [Gtk] Assert on ChromeClientGtk::scroll with delta (0, -1)

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[José Dapena Paz]

Steps to reproduce:
1. Build WK1-GTK  with Accelerated compositing and webgl enabled.
2. Run GtkLauncher
3. Open http://2012.beercamp.com

Outcome: crash due to the  assert.

Assert:
ASSERTION FAILED: !delta.isEmpty()

Backtrace:
#0  0x00007ffff531cc27 in WebKit::ChromeClient::scroll (this=0x59b780, delta=..., rectToScroll=..., clipRect=...) at ../../Source/WebKit/gtk/WebCoreSupport/ChromeClientGtk.cpp:654
#1  0x00007ffff5bdd09c in WebCore::Chrome::scroll (this=0x5bb7e0, scrollDelta=..., rectToScroll=..., clipRect=...) at ../../Source/WebCore/page/Chrome.cpp:97
#2  0x00007ffff5c2bf40 in WebCore::FrameView::scrollContentsFastPath (this=0x1780480, scrollDelta=..., rectToScroll=..., clipRect=...) at ../../Source/WebCore/page/FrameView.cpp:1554
#3  0x00007ffff5d7cd59 in WebCore::ScrollView::scrollContents (this=0x1780480, scrollDelta=...) at ../../Source/WebCore/platform/ScrollView.cpp:678
#4  0x00007ffff5d7b00f in WebCore::ScrollView::scrollTo (this=0x1780480, newOffset=...) at ../../Source/WebCore/platform/ScrollView.cpp:385
#5  0x00007ffff5c30714 in WebCore::FrameView::scrollTo (this=0x1780480, newOffset=...) at ../../Source/WebCore/page/FrameView.cpp:2693
#6  0x00007ffff5d7af68 in WebCore::ScrollView::setScrollOffset (this=0x1780480, offset=...) at ../../Source/WebCore/platform/ScrollView.cpp:365
#7  0x00007ffff5d741fa in WebCore::ScrollableArea::scrollPositionChanged (this=0x17804d0, position=...) at ../../Source/WebCore/platform/ScrollableArea.cpp:147
#8  0x00007ffff5d74491 in WebCore::ScrollableArea::setScrollOffsetFromAnimation (this=0x17804d0, offset=...) at ../../Source/WebCore/platform/ScrollableArea.cpp:192
#9  0x00007ffff5d712e1 in WebCore::ScrollAnimator::notifyPositionChanged (this=0x97f0c0) at ../../Source/WebCore/platform/ScrollAnimator.cpp:149
#10 0x00007ffff5d70c79 in WebCore::ScrollAnimator::scrollToOffsetWithoutAnimation (this=0x97f0c0, offset=...) at ../../Source/WebCore/platform/ScrollAnimator.cpp:79
#11 0x00007ffff5d74090 in WebCore::ScrollableArea::scrollToOffsetWithoutAnimation (this=0x17804d0, offset=...) at ../../Source/WebCore/platform/ScrollableArea.cpp:126
#12 0x00007ffff5d7c7fd in WebCore::ScrollView::updateScrollbars (this=0x1780480, desiredOffset=...) at ../../Source/WebCore/platform/ScrollView.cpp:623
#13 0x00007ffff5d7b203 in WebCore::ScrollView::setScrollPosition (this=0x1780480, scrollPoint=...) at ../../Source/WebCore/platform/ScrollView.cpp:420
#14 0x00007ffff5c2cd09 in WebCore::FrameView::setScrollPosition (this=0x1780480, scrollPoint=...) at ../../Source/WebCore/page/FrameView.cpp:1762
#15 0x00007ffff5bf91af in WebCore::DOMWindow::scrollTo (this=0x10c9e40, x=0, y=1) at ../../Source/WebCore/page/DOMWindow.cpp:1414
#16 0x00007ffff61e5c49 in WebCore::jsDOMWindowPrototypeFunctionScrollTo (exec=0x7fff86bfe088) at DerivedSources/WebCore/JSDOMWindow.cpp:9653
#17 0x00007fffab5a4265 in ?? ()
#18 0x00007fffffffc9f0 in ?? ()
#19 0x00007ffff3b80079 in llint_op_call () from /home/jose/Desarrollo/git/WebKit/WebKitBuild/Debug/.libs/libjavascriptcoregtk-3.0.so.0
#20 0x00007fffffffc980 in ?? ()
#21 0x00007fffffffc9b0 in ?? ()
#22 0x00007fff954f1d00 in ?? ()
#23 0x00007ffff3a84c77 in JSC::Register::Register (this=0x0) at ../../Source/JavaScriptCore/interpreter/Register.h:105
#24 0x00007ffff3b2d3aa in JSC::JITCode::execute (this=0x7fff8434ea68, registerFile=0x5ebb38, callFrame=0x7fff86bfe038, globalData=0x89fbe0) at ../../Source/JavaScriptCore/jit/JITCode.h:133
#25 0x00007ffff3b29cc0 in JSC::Interpreter::executeCall (this=0x5ebb20, callFrame=0x7fffa81cf388, function=0x7fff954f1d00, callType=JSC::CallTypeJS, callData=..., thisValue=..., args=...) at ../../Source/JavaScriptCore/interpreter/Interpreter.cpp:1045
#26 0x00007ffff3bf64b1 in JSC::call (exec=0x7fffa81cf388, functionObject=..., callType=JSC::CallTypeJS, callData=..., thisValue=..., args=...) at ../../Source/JavaScriptCore/runtime/CallData.cpp:39
#27 0x00007ffff5482bf3 in WebCore::JSMainThreadExecState::call (exec=0x7fffa81cf388, functionObject=..., callType=JSC::CallTypeJS, callData=..., thisValue=..., args=...) at ../../Source/WebCore/bindings/js/JSMainThreadExecState.h:56
#28 0x00007ffff54e6dbb in WebCore::ScheduledAction::executeFunctionInContext (this=0x2061030, globalObject=0x7fffa81cf180, thisValue=..., context=0x12454d8) at ../../Source/WebCore/bindings/js/ScheduledAction.cpp:115
#29 0x00007ffff54e6f92 in WebCore::ScheduledAction::execute (this=0x2061030, document=0x12453b0) at ../../Source/WebCore/bindings/js/ScheduledAction.cpp:137
#30 0x00007ffff54e6b32 in WebCore::ScheduledAction::execute (this=0x2061030, context=0x12454d8) at ../../Source/WebCore/bindings/js/ScheduledAction.cpp:83
#31 0x00007ffff5bf38a6 in WebCore::DOMTimer::fired (this=0xa9d7e0) at ../../Source/WebCore/page/DOMTimer.cpp:149
#32 0x00007ffff5da32b9 in WebCore::ThreadTimers::sharedTimerFiredInternal (this=0x5de160) at ../../Source/WebCore/platform/ThreadTimers.cpp:115
#33 0x00007ffff5da31e7 in WebCore::ThreadTimers::sharedTimerFired () at ../../Source/WebCore/platform/ThreadTimers.cpp:93
#34 0x00007ffff64c15ca in WebCore::timeout_cb () at ../../Source/WebCore/platform/gtk/SharedTimerGtk.cpp:49
#35 0x00007ffff471f379 in g_timeout_dispatch (source=0x9b8a10, callback=0x7ffff64c15a9 <WebCore::timeout_cb(gpointer)>, user_data=0x0) at gmain.c:3882
#36 0x00007ffff471d5ec in g_main_dispatch (context=0x472ef0) at gmain.c:2539
#37 0x00007ffff471e291 in g_main_context_dispatch (context=0x472ef0) at gmain.c:3075
#38 0x00007ffff471e474 in g_main_context_iterate (context=0x472ef0, block=1, dispatch=1, self=0x74d120) at gmain.c:3146
#39 0x00007ffff471e89d in g_main_loop_run (loop=0x76af00) at gmain.c:3340
#40 0x00007ffff4b871ae in gtk_main () at gtkmain.c:1161
#41 0x000000000040546d in main (argc=1, argv=0x7fffffffd268) at ../../Tools/GtkLauncher/main.c:534

[José Dapena Paz]

Created attachment 161738 [details]
Patch

[Martin Robinson]

Comment on attachment 161738 [details]
Patch

Great! Thanks.

[WebKit Review Bot]

Comment on attachment 161738 [details]
Patch

Clearing flags on attachment: 161738

Committed r127328: <http://trac.webkit.org/changeset/127328>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.