RESOLVED FIXED95586
[New Multicolumn] Refactor flow thread repainting. 
https://bugs.webkit.org/show_bug.cgi?id=95586
Summary [New Multicolumn] Refactor flow thread repainting.
Dave Hyatt
Reported 2012-08-31 09:53:22 PDT
Refactor flow thread repainting so that it calls into regions to have them do the repainting. This will allow us to subclass in RenderMultiColumnSet to do the right thing. The bulk of the work has moved into a parameterized helper that will be called by derived classes.
Attachments
Patch (12.44 KB, patch)
2012-08-31 09:56 PDT, Dave Hyatt 		simon.fraser: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dave Hyatt
Comment 1 2012-08-31 09:56:47 PDT
Created attachment 161724 [details] Patch
Simon Fraser (smfr)
Comment 2 2012-08-31 10:27:06 PDT
Comment on attachment 161724 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=161724&action=review > Source/WebCore/ChangeLog:10 > + inside sets. Not sure what "sets" are in this context. > Source/WebCore/rendering/RenderFlowThread.cpp:322 > + // We can't use currentFlowThread as it is possible to have imbricated flow threads and the wrong one could be used. 99.9% of people won't know what "imbricated" means, even though it's cool. Maybe "overlapping"? > Source/WebCore/rendering/RenderRegion.h:72 > + Redundant whitespace
Dave Hyatt
Comment 3 2012-08-31 10:29:00 PDT
(In reply to comment #2) > > 99.9% of people won't know what "imbricated" means, even though it's cool. Maybe "overlapping"? > I just moved that comment. Don't blame me! I'll change it to interleaved.
Dave Hyatt
Comment 4 2012-08-31 10:37:23 PDT
Landed in r127280.
Note You need to log in before you can comment on or make changes to this bug.