Bug 95585 - Web Inspector: Implement SCSS source highlighter
Summary: Web Inspector: Implement SCSS source highlighter
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Alexander Pavlov (apavlov)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-08-31 09:31 PDT by Alexander Pavlov (apavlov)
Modified: 2012-09-07 06:24 PDT (History)
10 users (show)

See Also:

Attachments
Patch (106.60 KB, patch)
2012-09-03 07:13 PDT, Alexander Pavlov (apavlov) 		no flags Details | Formatted Diff | Diff
Patch (131.07 KB, patch)
2012-09-03 08:18 PDT, Alexander Pavlov (apavlov) 		no flags Details | Formatted Diff | Diff
Rebased patch (130.94 KB, patch)
2012-09-05 01:59 PDT, Alexander Pavlov (apavlov) 		no flags Details | Formatted Diff | Diff
Patch (129.74 KB, patch)
2012-09-06 01:35 PDT, Alexander Pavlov (apavlov) 		vsevik: review+
Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexander Pavlov (apavlov) 2012-08-31 09:31:58 PDT 
Patch to follow.
Comment 1 Alexander Pavlov (apavlov) 2012-09-03 07:13:40 PDT 
Created attachment 161922 [details]
Patch
Comment 2 Pavel Feldman 2012-09-03 07:45:48 PDT 
Comment on attachment 161922 [details]
Patch

Could you reuse the CSS and join them?
Comment 3 Alexander Pavlov (apavlov) 2012-09-03 08:18:16 PDT 
Created attachment 161933 [details]
Patch
Comment 4 Alexander Pavlov (apavlov) 2012-09-05 01:59:25 PDT 
Created attachment 162191 [details]
Rebased patch
Comment 5 Alexander Pavlov (apavlov) 2012-09-06 01:35:48 PDT 
Created attachment 162449 [details]
Patch
Comment 6 Vsevolod Vlasov 2012-09-07 01:52:28 PDT 
Comment on attachment 162449 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=162449&action=review

> Source/WebCore/inspector/front-end/ContentProviders.js:274
> +    mimeType: function()

This one is redundant, please remove.
Comment 7 Vsevolod Vlasov 2012-09-07 06:09:00 PDT 
Comment on attachment 162449 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=162449&action=review

This makes me sick. lgtm.

> Source/WebCore/inspector/front-end/SourceCSSTokenizer.re2js:80
> +WebInspector.SourceCSSTokenizer.AtRelatedKeywords = [

SCSSAt..
Comment 8 Alexander Pavlov (apavlov) 2012-09-07 06:24:24 PDT 
Committed r127864: <http://trac.webkit.org/changeset/127864>