WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
95585
Web Inspector: Implement SCSS source highlighter
https://bugs.webkit.org/show_bug.cgi?id=95585
Summary
Web Inspector: Implement SCSS source highlighter
Alexander Pavlov (apavlov)
Reported
2012-08-31 09:31:58 PDT
Patch to follow.
Attachments
Patch
(106.60 KB, patch)
2012-09-03 07:13 PDT
,
Alexander Pavlov (apavlov)
no flags
Details
Formatted Diff
Diff
Patch
(131.07 KB, patch)
2012-09-03 08:18 PDT
,
Alexander Pavlov (apavlov)
no flags
Details
Formatted Diff
Diff
Rebased patch
(130.94 KB, patch)
2012-09-05 01:59 PDT
,
Alexander Pavlov (apavlov)
no flags
Details
Formatted Diff
Diff
Patch
(129.74 KB, patch)
2012-09-06 01:35 PDT
,
Alexander Pavlov (apavlov)
vsevik
: review+
Details
Formatted Diff
Diff
Show Obsolete
(3)
View All
Add attachment
proposed patch, testcase, etc.
Alexander Pavlov (apavlov)
Comment 1
2012-09-03 07:13:40 PDT
Created
attachment 161922
[details]
Patch
Pavel Feldman
Comment 2
2012-09-03 07:45:48 PDT
Comment on
attachment 161922
[details]
Patch Could you reuse the CSS and join them?
Alexander Pavlov (apavlov)
Comment 3
2012-09-03 08:18:16 PDT
Created
attachment 161933
[details]
Patch
Alexander Pavlov (apavlov)
Comment 4
2012-09-05 01:59:25 PDT
Created
attachment 162191
[details]
Rebased patch
Alexander Pavlov (apavlov)
Comment 5
2012-09-06 01:35:48 PDT
Created
attachment 162449
[details]
Patch
Vsevolod Vlasov
Comment 6
2012-09-07 01:52:28 PDT
Comment on
attachment 162449
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=162449&action=review
> Source/WebCore/inspector/front-end/ContentProviders.js:274 > + mimeType: function()
This one is redundant, please remove.
Vsevolod Vlasov
Comment 7
2012-09-07 06:09:00 PDT
Comment on
attachment 162449
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=162449&action=review
This makes me sick. lgtm.
> Source/WebCore/inspector/front-end/SourceCSSTokenizer.re2js:80 > +WebInspector.SourceCSSTokenizer.AtRelatedKeywords = [
SCSSAt..
Alexander Pavlov (apavlov)
Comment 8
2012-09-07 06:24:24 PDT
Committed
r127864
: <
http://trac.webkit.org/changeset/127864
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug