Bug 95567 - Web Inspector: get rid of context execution id fallback.
Summary: Web Inspector: get rid of context execution id fallback.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Pavel Feldman
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-08-31 07:01 PDT by Pavel Feldman
Modified: 2012-09-03 01:54 PDT (History)
10 users (show)

See Also:

Attachments
Patch (22.65 KB, patch)
2012-08-31 08:52 PDT, Pavel Feldman 		no flags Details | Formatted Diff | Diff
Patch (23.96 KB, patch)
2012-09-03 01:40 PDT, Pavel Feldman 		yurys: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Feldman 2012-08-31 07:01:44 PDT 
We now assign execution id upon UI population.
Comment 1 Pavel Feldman 2012-08-31 08:52:33 PDT 
Created attachment 161709 [details]
Patch
Comment 2 Yury Semikhatsky 2012-09-03 01:28:11 PDT 
Comment on attachment 161709 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=161709&action=review

> Source/WebCore/inspector/front-end/ConsoleView.js:47
> +    this._contextSelector = new WebInspector.StatusBarComboBox(this._updateExecutionContextSelector.bind(this), "console-context");

Let's rename _contextSelector to _frameSelector or _contextListSelector.

> Source/WebCore/inspector/front-end/JavaScriptContextManager.js:103
> +        var cpmtextList = this._frameIdToContextList[context.frameId];

cpmtextList ?
Comment 3 Pavel Feldman 2012-09-03 01:40:25 PDT 
Created attachment 161879 [details]
Patch
Comment 4 Pavel Feldman 2012-09-03 01:54:27 PDT 
Committed r127412: <http://trac.webkit.org/changeset/127412>