Bug 95558 - [Qt] The LayerTreeRenderer::callOnMainTread method name is misleading
Summary: [Qt] The LayerTreeRenderer::callOnMainTread method name is misleading
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Balazs Kelemen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-08-31 04:58 PDT by Balazs Kelemen
Modified: 2012-08-31 10:08 PDT (History)
3 users (show)

See Also:

Attachments
Patch (3.43 KB, patch)
2012-08-31 05:03 PDT, Balazs Kelemen 		no flags Details | Formatted Diff | Diff
Patch (3.41 KB, patch)
2012-08-31 05:49 PDT, Balazs Kelemen 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Balazs Kelemen 2012-08-31 04:58:36 PDT 
This is a typo. The function is actually named callOnMainTread (no h), but call sites spells it correctly so they call WTF::callOnMainThread.
Comment 1 Balazs Kelemen 2012-08-31 05:03:01 PDT 
Created attachment 161668 [details]
Patch
Comment 2 Rafael Brandao 2012-08-31 05:12:56 PDT 
Comment on attachment 161668 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=161668&action=review

> Source/WebKit2/ChangeLog:3
> +        [Qt] LayerTreeRenderer::callOnMainThread is brokken like this senteance

You should rewrite this bug title, it's not clear what are you trying to fix by reading that and there are typos ("broken" and "sentence").

> Source/WebKit2/ChangeLog:10
> +        make it clear that these things are not the same.

Could you explain the difference? For some reason I think "call" is more clear, but maybe I didn't get what this is actually doing.
Comment 3 Balazs Kelemen 2012-08-31 05:49:13 PDT 
Created attachment 161677 [details]
Patch
Comment 4 Kenneth Rohde Christiansen 2012-08-31 05:52:26 PDT 
Comment on attachment 161677 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=161677&action=review

> Source/WebKit2/ChangeLog:3
> +        [Qt] LayerTreeRenderer::callOnMainThread is mistyped

I changed the bug name as this is even more misleading... it sounds like it is using wrong types
Comment 5 Balazs Kelemen 2012-08-31 05:53:56 PDT 
(In reply to comment #4)
> (From update of attachment 161677 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=161677&action=review
> 
> > Source/WebKit2/ChangeLog:3
> > +        [Qt] LayerTreeRenderer::callOnMainThread is mistyped
> 
> I changed the bug name as this is even more misleading... it sounds like it is using wrong types

Ok, right, I actually uploaded a new patch but I can fix the changelog title before landing.
Comment 6 Kenneth Rohde Christiansen 2012-08-31 06:00:26 PDT 
Comment on attachment 161677 [details]
Patch

That is fine
Comment 7 Balazs Kelemen 2012-08-31 10:08:26 PDT 
Landed in http://trac.webkit.org/changeset/127273