Bug 95558 – [Qt] The LayerTreeRenderer::callOnMainTread method name is misleading

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Balazs Kelemen]

This is a typo. The function is actually named callOnMainTread (no h), but call sites spells it correctly so they call WTF::callOnMainThread.

[Balazs Kelemen]

Created attachment 161668 [details]
Patch

[Rafael Brandao]

Comment on attachment 161668 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=161668&action=review

> Source/WebKit2/ChangeLog:3
> +        [Qt] LayerTreeRenderer::callOnMainThread is brokken like this senteance

You should rewrite this bug title, it's not clear what are you trying to fix by reading that and there are typos ("broken" and "sentence").

> Source/WebKit2/ChangeLog:10
> +        make it clear that these things are not the same.

Could you explain the difference? For some reason I think "call" is more clear, but maybe I didn't get what this is actually doing.

[Balazs Kelemen]

Created attachment 161677 [details]
Patch

[Kenneth Rohde Christiansen]

Comment on attachment 161677 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=161677&action=review

> Source/WebKit2/ChangeLog:3
> +        [Qt] LayerTreeRenderer::callOnMainThread is mistyped

I changed the bug name as this is even more misleading... it sounds like it is using wrong types

[Balazs Kelemen]

(In reply to comment #4)
> (From update of attachment 161677 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=161677&action=review
> 
> > Source/WebKit2/ChangeLog:3
> > +        [Qt] LayerTreeRenderer::callOnMainThread is mistyped
> 
> I changed the bug name as this is even more misleading... it sounds like it is using wrong types

Ok, right, I actually uploaded a new patch but I can fix the changelog title before landing.

[Kenneth Rohde Christiansen]

Comment on attachment 161677 [details]
Patch

That is fine

[Balazs Kelemen]

Landed in http://trac.webkit.org/changeset/127273