Bug 95550 – Build warning : -Wformat on WebMemorySampler.cpp.

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Misc.

[Byungwoo Lee]

Fix build warning -Wformat on WebMemorySampler.cpp by adding explicit casting.

[Byungwoo Lee]

Created attachment 161658 [details]
Patch

[Gyuyoung Kim]

Comment on attachment 161658 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=161658&action=review

> Source/WebKit2/Shared/WebMemorySampler.cpp:178
> +            statString.append(String::format("%lu", static_cast<long unsigned int>(memoryStats.values[i])));

Is it enough *unsigned long* ?

[Darin Adler]

Comment on attachment 161658 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=161658&action=review

A better fix would probably be to use String::number instead of String::format.

>> Source/WebKit2/Shared/WebMemorySampler.cpp:178
>> +            statString.append(String::format("%lu", static_cast<long unsigned int>(memoryStats.values[i])));
> 
> Is it enough *unsigned long* ?

That’s right. In our code we use the name “unsigned long” for this type, not “long unsigned int”, which is equivalent, but not idiomatic. When landing this please use “unsigned long” rather than “long unsigned int”.

[Byungwoo Lee]

Created attachment 161801 [details]
Patch

[Byungwoo Lee]

Ok I applied that. Thanks for all your comments :)

[Byungwoo Lee]

Created attachment 161805 [details]
Patch

[Gyuyoung Kim]

Comment on attachment 161805 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=161805&action=review

> Source/WebKit2/Shared/WebMemorySampler.cpp:178
> +            statString.append(String::format("%lu", static_cast<unsigned long>(memoryStats.values[i])));

As Darin said, please use String::number instead of String::format.

[Byungwoo Lee]

(In reply to comment #7)
> (From update of attachment 161805 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=161805&action=review
> 
> > Source/WebKit2/Shared/WebMemorySampler.cpp:178
> > +            statString.append(String::format("%lu", static_cast<unsigned long>(memoryStats.values[i])));
> 
> As Darin said, please use String::number instead of String::format.

Sorry for my carelessness.
I didn't read the upper part about String::number.

I'll apply those and upload again.
Thanks :)

[Byungwoo Lee]

Created attachment 161811 [details]
Patch

[WebKit Review Bot]

Comment on attachment 161811 [details]
Patch

Clearing flags on attachment: 161811

Committed r127353: <http://trac.webkit.org/changeset/127353>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.