WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
95545
[Tests] fast/forms/time-multiple-fields/time-multiple-fields-appearance-*.html should dump text instead of render tree
https://bugs.webkit.org/show_bug.cgi?id=95545
Summary
[Tests] fast/forms/time-multiple-fields/time-multiple-fields-appearance-*.htm...
yosin
Reported
2012-08-31 02:53:46 PDT
For appearance tests, structure of render tree isn't important for testing.
Attachments
Patch 1
(118.28 KB, patch)
2012-08-31 03:12 PDT
,
yosin
no flags
Details
Formatted Diff
Diff
Patch 2
(121.81 KB, patch)
2012-08-31 03:30 PDT
,
yosin
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
yosin
Comment 1
2012-08-31 03:12:05 PDT
Created
attachment 161648
[details]
Patch 1
yosin
Comment 2
2012-08-31 03:12:53 PDT
Comment on
attachment 161648
[details]
Patch 1 Could you review this patch? Thanks in advance.
Kent Tamura
Comment 3
2012-08-31 03:23:27 PDT
Comment on
attachment 161648
[details]
Patch 1 dumpAsText(true) is needed. text expectation should be updated.
yosin
Comment 4
2012-08-31 03:30:27 PDT
Created
attachment 161652
[details]
Patch 2
yosin
Comment 5
2012-08-31 03:31:40 PDT
Comment on
attachment 161652
[details]
Patch 2 Could you review this patch? Thanks in advance. = Changes since the last review = * Added fast/forms/time-multiple-fields/*-expected.txt * Changed to dumpAsText(true) in HTML fiels * Update ChangeLog
Kent Tamura
Comment 6
2012-09-02 17:59:59 PDT
Comment on
attachment 161652
[details]
Patch 2 ok
yosin
Comment 7
2012-09-02 18:04:38 PDT
Comment on
attachment 161652
[details]
Patch 2 Clearing flags on attachment: 161652 Committed
r127396
: <
http://trac.webkit.org/changeset/127396
>
yosin
Comment 8
2012-09-02 18:04:42 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug