Bug 95540 - Web Inspector: use linkifyResourceAsNode, not linkifyLocation when linkifying resources in Timeline
Summary: Web Inspector: use linkifyResourceAsNode, not linkifyLocation when linkifying...
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Andrey Kosyakov
Depends on:
Reported: 2012-08-31 02:02 PDT by Andrey Kosyakov
Modified: 2012-09-03 02:57 PDT (History)
11 users (show)

See Also:

Patch (2.76 KB, patch)
2012-08-31 02:06 PDT, Andrey Kosyakov
pfeldman: review+
webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andrey Kosyakov 2012-08-31 02:02:44 PDT
linkifyLocation requires line number and is for linkifying location within potentially source-mapped resources, so use linkifyResoruceAsNode for resource-related records (ScheduleResourceRequest..ResourceFinish).
Comment 1 Andrey Kosyakov 2012-08-31 02:06:15 PDT
Created attachment 161643 [details]
Comment 2 WebKit Review Bot 2012-08-31 02:56:33 PDT
Comment on attachment 161643 [details]

Rejecting attachment 161643 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1

ERROR: /mnt/git/webkit-commit-queue/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: http://queues.webkit.org/results/13714149
Comment 3 Andrey Kosyakov 2012-09-03 02:57:15 PDT
Committed r127415: <http://trac.webkit.org/changeset/127415>