Bug 95529 - [chromium] Rename WebViewClient::handleDisambiguationPopup
Summary: [chromium] Rename WebViewClient::handleDisambiguationPopup
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-08-30 23:25 PDT by Tien-Ren Chen
Modified: 2012-09-04 13:25 PDT (History)
6 users (show)

See Also:

Attachments
Patch (3.42 KB, patch)
2012-08-30 23:26 PDT, Tien-Ren Chen 		no flags Details | Formatted Diff | Diff
Patch (3.42 KB, patch)
2012-08-31 16:59 PDT, Tien-Ren Chen 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tien-Ren Chen 2012-08-30 23:25:32 PDT 
[chromium] Rename WebViewClient::handleDisambiguationPopup
Comment 1 Tien-Ren Chen 2012-08-30 23:26:46 PDT 
Created attachment 161622 [details]
Patch
Comment 2 WebKit Review Bot 2012-08-30 23:28:10 PDT 
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Comment 3 Adam Barth 2012-08-31 11:36:13 PDT 
Comment on attachment 161622 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=161622&action=review

> Source/WebKit/chromium/public/WebViewClient.h:291
> -    virtual bool handleDisambiguationPopup(const WebGestureEvent&, const WebVector<WebRect>& targetRects) { return false; }
> +    virtual bool multipleTargetsTapped(const WebGestureEvent&, const WebVector<WebRect>& targetRects) { return false; }

didTapMultipleTargets or willTapMultipleTargets?
Comment 4 Darin Fisher (:fishd, Google) 2012-08-31 15:51:18 PDT 
Comment on attachment 161622 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=161622&action=review

>> Source/WebKit/chromium/public/WebViewClient.h:291
>> +    virtual bool multipleTargetsTapped(const WebGestureEvent&, const WebVector<WebRect>& targetRects) { return false; }
> 
> didTapMultipleTargets or willTapMultipleTargets?

+1 ... probably didTap* since this is called from handleGestureEvent.  The tap already happened.
Comment 5 Tien-Ren Chen 2012-08-31 16:59:02 PDT 
Created attachment 161792 [details]
Patch
Comment 6 WebKit Review Bot 2012-09-04 13:25:23 PDT 
Comment on attachment 161792 [details]
Patch

Clearing flags on attachment: 161792

Committed r127494: <http://trac.webkit.org/changeset/127494>
Comment 7 WebKit Review Bot 2012-09-04 13:25:26 PDT 
All reviewed patches have been landed.  Closing bug.