RESOLVED FIXED 95529
[chromium] Rename WebViewClient::handleDisambiguationPopup 
https://bugs.webkit.org/show_bug.cgi?id=95529
Summary [chromium] Rename WebViewClient::handleDisambiguationPopup
Tien-Ren Chen
Reported 2012-08-30 23:25:32 PDT
[chromium] Rename WebViewClient::handleDisambiguationPopup
Attachments
Patch (3.42 KB, patch)
2012-08-30 23:26 PDT, Tien-Ren Chen 		no flags
DetailsFormatted DiffDiff
Patch (3.42 KB, patch)
2012-08-31 16:59 PDT, Tien-Ren Chen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Tien-Ren Chen
Comment 1 2012-08-30 23:26:46 PDT
Created attachment 161622 [details] Patch
WebKit Review Bot
Comment 2 2012-08-30 23:28:10 PDT
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Adam Barth
Comment 3 2012-08-31 11:36:13 PDT
Comment on attachment 161622 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=161622&action=review > Source/WebKit/chromium/public/WebViewClient.h:291 > - virtual bool handleDisambiguationPopup(const WebGestureEvent&, const WebVector<WebRect>& targetRects) { return false; } > + virtual bool multipleTargetsTapped(const WebGestureEvent&, const WebVector<WebRect>& targetRects) { return false; } didTapMultipleTargets or willTapMultipleTargets?
Darin Fisher (:fishd, Google)
Comment 4 2012-08-31 15:51:18 PDT
Comment on attachment 161622 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=161622&action=review >> Source/WebKit/chromium/public/WebViewClient.h:291 >> + virtual bool multipleTargetsTapped(const WebGestureEvent&, const WebVector<WebRect>& targetRects) { return false; } > > didTapMultipleTargets or willTapMultipleTargets? +1 ... probably didTap* since this is called from handleGestureEvent. The tap already happened.
Tien-Ren Chen
Comment 5 2012-08-31 16:59:02 PDT
Created attachment 161792 [details] Patch
WebKit Review Bot
Comment 6 2012-09-04 13:25:23 PDT
Comment on attachment 161792 [details] Patch Clearing flags on attachment: 161792 Committed r127494: <http://trac.webkit.org/changeset/127494>
WebKit Review Bot
Comment 7 2012-09-04 13:25:26 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.