Bug 95525 - [Forms] Blur from field should reset typeahead buffer in multiple fields time input UI
Summary: [Forms] Blur from field should reset typeahead buffer in multiple fields time...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Forms (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: yosin
URL:
Keywords:
Depends on: 95168
Blocks:
  Show dependency tree / graph
 
Reported: 2012-08-30 20:38 PDT by yosin
Modified: 2012-08-30 23:31 PDT (History)
1 user (show)

See Also:

Attachments
Patch 1 (5.60 KB, patch)
2012-08-30 21:39 PDT, yosin 		no flags Details | Formatted Diff | Diff
Patch 2 (5.63 KB, patch)
2012-08-30 21:58 PDT, yosin 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description yosin 2012-08-30 20:38:08 PDT 
When following scenario in one second, we expect the value is "00:02:34" but actual value is "00:12:34".

1. Move focus to minute field in <input type="time" value="00:00:34">
2. Type "1" to set value "00:01:34"
3. Hit Tab key to move focus to second field
4. Hit Shift+Tab key to move focus to minute field
5. Type "2"
Comment 1 yosin 2012-08-30 21:39:30 PDT 
Created attachment 161617 [details]
Patch 1
Comment 2 yosin 2012-08-30 21:40:09 PDT 
Comment on attachment 161617 [details]
Patch 1

Could you review this patch?
Thanks in advance.
Comment 3 Kent Tamura 2012-08-30 21:44:52 PDT 
Comment on attachment 161617 [details]
Patch 1

View in context: https://bugs.webkit.org/attachment.cgi?id=161617&action=review

> Source/WebCore/html/shadow/DateTimeNumericFieldElement.cpp:78
> +void DateTimeNumericFieldElement::didBlur()
> +{
> +    m_lastDigitCharTime = 0;
> +}

should call DateTimeFieldElement::didBlur().
Comment 4 yosin 2012-08-30 21:58:24 PDT 
Created attachment 161618 [details]
Patch 2
Comment 5 yosin 2012-08-30 21:59:55 PDT 
Comment on attachment 161618 [details]
Patch 2

Could you review this patch?
Thanks in advance.

= Changes since the last review =
* Added to call DateTimeFieldElement::didBlur() in DateTimeNumericFieldElement::didBlur()
Comment 6 Kent Tamura 2012-08-30 23:20:16 PDT 
Comment on attachment 161618 [details]
Patch 2

ok
Comment 7 yosin 2012-08-30 23:31:15 PDT 
Comment on attachment 161618 [details]
Patch 2

Clearing flags on attachment: 161618

Committed r127234: <http://trac.webkit.org/changeset/127234>
Comment 8 yosin 2012-08-30 23:31:19 PDT 
All reviewed patches have been landed.  Closing bug.