Bug 95497 - ~JSNPObject should call invalidate() if it hasn't been called already
Summary: ~JSNPObject should call invalidate() if it hasn't been called already
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Hahnenberg
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-08-30 13:59 PDT by Mark Hahnenberg
Modified: 2012-08-30 17:42 PDT (History)
2 users (show)

See Also:

Attachments
Patch (1.98 KB, patch)
2012-08-30 14:01 PDT, Mark Hahnenberg 		no flags Details | Formatted Diff | Diff
Patch (1.34 KB, patch)
2012-08-30 14:34 PDT, Mark Hahnenberg 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Hahnenberg 2012-08-30 13:59:59 PDT 
Finalization is no longer eager, just like destruction, so the original intent behind this ASSERT in ~JSNPObject is no longer relevant. Therefore, we can remove all destruction-related stuff from JSNPObject.
Comment 1 Mark Hahnenberg 2012-08-30 14:01:36 PDT 
Created attachment 161551 [details]
Patch
Comment 2 Mark Hahnenberg 2012-08-30 14:08:30 PDT 
http://trac.webkit.org/changeset/121316 is the change that caused this new behavior. It was meant to remove this ASSERT, but it was overlooked.
Comment 3 Geoffrey Garen 2012-08-30 14:18:24 PDT 
Comment on attachment 161551 [details]
Patch

Still need a destructor so we don't leak the np object.
Comment 4 Mark Hahnenberg 2012-08-30 14:34:08 PDT 
Created attachment 161558 [details]
Patch
Comment 5 Geoffrey Garen 2012-08-30 15:15:37 PDT 
Comment on attachment 161558 [details]
Patch

r=me
Comment 6 WebKit Review Bot 2012-08-30 17:42:51 PDT 
Comment on attachment 161558 [details]
Patch

Clearing flags on attachment: 161558

Committed r127219: <http://trac.webkit.org/changeset/127219>
Comment 7 WebKit Review Bot 2012-08-30 17:42:54 PDT 
All reviewed patches have been landed.  Closing bug.