Bug 95482 - JSC: Render unto #ifdef's that which belong to them
Summary: JSC: Render unto #ifdef's that which belong to them
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-08-30 11:10 PDT by Mark Lam
Modified: 2012-08-30 15:21 PDT (History)
4 users (show)

See Also:


Attachments
Fix. (27.46 KB, patch)
2012-08-30 11:26 PDT, Mark Lam
fpizlo: review+
gyuyoung.kim: commit-queue-
Details | Formatted Diff | Diff
Fix HAVE(COMPUTED_GOTO) && !ENABLE(COMPUTED_GOTO_CLASSIC_INTERPRETER) case. (27.50 KB, patch)
2012-08-30 13:49 PDT, Mark Lam
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2012-08-30 11:10:56 PDT
Refining / disambiguating between #ifdefs and adding some.  For example, ENABLE(JIT) is conflated with ENABLE(LLINT) in some places.  Also, we need to add ENABLE(COMPUTED_GOTO_OPCODES) to indicate that we want interpreted opcodes to use COMPUTED GOTOs apart from ENABLE(LLINT) and ENABLE(COMPUTED_GOTO_CLASSIC_INTERPRETER).  Also cleaned up #ifdefs in certain places which were previously incorrect.

With current build configurations, this change does not make much difference.  But we'll need this later for the LLInt C loop.
Comment 1 Mark Lam 2012-08-30 11:26:54 PDT
Created attachment 161522 [details]
Fix.
Comment 2 Gyuyoung Kim 2012-08-30 12:42:58 PDT
Comment on attachment 161522 [details]
Fix.

Attachment 161522 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/13703008
Comment 3 Early Warning System Bot 2012-08-30 12:46:21 PDT
Comment on attachment 161522 [details]
Fix.

Attachment 161522 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/13681805
Comment 4 Early Warning System Bot 2012-08-30 13:24:14 PDT
Comment on attachment 161522 [details]
Fix.

Attachment 161522 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/13687805
Comment 5 Mark Lam 2012-08-30 13:49:15 PDT
Created attachment 161548 [details]
Fix HAVE(COMPUTED_GOTO) && !ENABLE(COMPUTED_GOTO_CLASSIC_INTERPRETER) case.

I missed the case where someone may want to build the classic interpreter without compute gotos even when HAVE(COMPUTED_GOTO) is defined.  Anyway, this is now fixed by not enabling ENABLE(COMPUTED_GOTO_OPCODES) when !ENABLE(COMPUTED_GOTO_CLASSIC_INTERPRETER).
Comment 6 WebKit Review Bot 2012-08-30 15:21:26 PDT
Comment on attachment 161548 [details]
Fix HAVE(COMPUTED_GOTO) && !ENABLE(COMPUTED_GOTO_CLASSIC_INTERPRETER) case.

Clearing flags on attachment: 161548

Committed r127199: <http://trac.webkit.org/changeset/127199>
Comment 7 WebKit Review Bot 2012-08-30 15:21:30 PDT
All reviewed patches have been landed.  Closing bug.