Bug 95482 – JSC: Render unto #ifdef's that which belong to them

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Mark Lam]

Refining / disambiguating between #ifdefs and adding some.  For example, ENABLE(JIT) is conflated with ENABLE(LLINT) in some places.  Also, we need to add ENABLE(COMPUTED_GOTO_OPCODES) to indicate that we want interpreted opcodes to use COMPUTED GOTOs apart from ENABLE(LLINT) and ENABLE(COMPUTED_GOTO_CLASSIC_INTERPRETER).  Also cleaned up #ifdefs in certain places which were previously incorrect.

With current build configurations, this change does not make much difference.  But we'll need this later for the LLInt C loop.

[Mark Lam]

Created attachment 161522 [details]
Fix.

[Gyuyoung Kim]

Comment on attachment 161522 [details]
Fix.

Attachment 161522 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/13703008

[Early Warning System Bot]

Comment on attachment 161522 [details]
Fix.

Attachment 161522 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/13681805

[Early Warning System Bot]

Comment on attachment 161522 [details]
Fix.

Attachment 161522 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/13687805

[Mark Lam]

Created attachment 161548 [details]
Fix HAVE(COMPUTED_GOTO) && !ENABLE(COMPUTED_GOTO_CLASSIC_INTERPRETER) case.

I missed the case where someone may want to build the classic interpreter without compute gotos even when HAVE(COMPUTED_GOTO) is defined.  Anyway, this is now fixed by not enabling ENABLE(COMPUTED_GOTO_OPCODES) when !ENABLE(COMPUTED_GOTO_CLASSIC_INTERPRETER).

[WebKit Review Bot]

Comment on attachment 161548 [details]
Fix HAVE(COMPUTED_GOTO) && !ENABLE(COMPUTED_GOTO_CLASSIC_INTERPRETER) case.

Clearing flags on attachment: 161548

Committed r127199: <http://trac.webkit.org/changeset/127199>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.