Bug 95480 - Repaints should not be deferred after initial page load is complete
Summary: Repaints should not be deferred after initial page load is complete
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Page Loading (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2012-08-30 10:52 PDT by Antti Koivisto
Modified: 2012-09-02 03:34 PDT (History)
7 users (show)

See Also:


Attachments
patch (8.94 KB, patch)
2012-08-31 10:25 PDT, Antti Koivisto
simon.fraser: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2012-08-30 10:52:21 PDT
Any dynamically triggered resource loading currently sends us back to deferred paint mode, making animation choppy. This is not the intention of this code.
Comment 1 Antti Koivisto 2012-08-30 10:54:42 PDT
<rdar://problem/12163073>
Comment 2 Antti Koivisto 2012-08-31 10:25:55 PDT
Created attachment 161727 [details]
patch
Comment 3 Simon Fraser (smfr) 2012-08-31 10:41:30 PDT
Comment on attachment 161727 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=161727&action=review

> Source/WebCore/ChangeLog:21
> +        (WebCore):

You can remove this line.

> Source/WebCore/loader/FrameLoader.cpp:758
> +        m_frame->view()->checkStopDelayingDeferredRepaints();

I have a hard time parsing this function name. Maybe we can rename it?

> Source/WebCore/page/FrameView.cpp:104
> +double FrameView::s_normalDeferredRepaintDelay = 0.025;

Should we make this 16ms to avoid crapping on animations?

> Source/WebCore/page/FrameView.cpp:2059
> +    double increamentedRepaintDelay = m_deferredRepaintDelay + s_deferredRepaintDelayIncrementDuringLoading;

increamentedRepaintDelay -> incrementedRepaintDelay
Comment 4 Antti Koivisto 2012-09-02 03:34:10 PDT
http://trac.webkit.org/changeset/127388