Bug 95477 – [Mountain Lion] platform/mac/editing/spelling/removing-underline-after-accepting-autocorrection-using-punctuation.html failing

• Status: RESOLVED
• Resolution: FIXED
• Component: HTML Editing

[Jessie Berlin]

http://build.webkit.org/results/Apple%20MountainLion%20Debug%20WK1%20(Tests)/r127141%20(366)/platform/mac/editing/spelling/removing-underline-after-accepting-autocorrection-using-punctuation-pretty-diff.html
http://build.webkit.org/results/Apple%20MountainLion%20Release%20WK1%20(Tests)/r127142%20(422)/platform/mac/editing/spelling/removing-underline-after-accepting-autocorrection-using-punctuation-pretty-diff.html
http://build.webkit.org/results/Apple%20MountainLion%20Debug%20WK2%20(Tests)/r127141%20(437)/platform/mac/editing/spelling/removing-underline-after-accepting-autocorrection-using-punctuation-pretty-diff.html
http://build.webkit.org/results/Apple%20MountainLion%20Release%20WK2%20(Tests)/r127142%20(428)/platform/mac/editing/spelling/removing-underline-after-accepting-autocorrection-using-punctuation-pretty-diff.html

The results in platform/mac seem to be passing on Lion but failing on Mountain Lion.

There is also a .png result in platform/mac. Is that expected? Is one needed for Mountain Lion?

--- /Volumes/Data/slave/mountainlion-debug-tests-wk1/build/layout-test-results/platform/mac/editing/spelling/removing-underline-after-accepting-autocorrection-using-punctuation-expected.txt
+++ /Volumes/Data/slave/mountainlion-debug-tests-wk1/build/layout-test-results/platform/mac/editing/spelling/removing-underline-after-accepting-autocorrection-using-punctuation-actual.txt
@@ -4,77 +4,47 @@
 EDITING DELEGATE: shouldChangeSelectedDOMRange:range from 0 of DIV > BODY > HTML > #document to 0 of DIV > BODY > HTML > #document toDOMRange:range from 1 of #text > DIV > BODY > HTML > #document to 1 of #text > DIV > BODY > HTML > #document affinity:NSSelectionAffinityDownstream stillSelecting:FALSE
 EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
 EDITING DELEGATE: webViewDidChange:WebViewDidChangeNotification
+EDITING DELEGATE: shouldChangeSelectedDOMRange:range from 1 of #text > DIV > BODY > HTML > #document to 1 of #text > DIV > BODY > HTML > #document toDOMRange:range from 2 of #text > DIV > BODY > HTML > #document to 2 of #text > DIV > BODY > HTML > #document affinity:NSSelectionAffinityDownstream stillSelecting:FALSE
 EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
-EDITING DELEGATE: shouldChangeSelectedDOMRange:range from 1 of #text > DIV > BODY > HTML > #document to 2 of #text > DIV > BODY > HTML > #document toDOMRange:range from 2 of #text > DIV > BODY > HTML > #document to 2 of #text > DIV > BODY > HTML > #document affinity:NSSelectionAffinityDownstream stillSelecting:FALSE
+EDITING DELEGATE: webViewDidChange:WebViewDidChangeNotification
+EDITING DELEGATE: shouldChangeSelectedDOMRange:range from 2 of #text > DIV > BODY > HTML > #document to 2 of #text > DIV > BODY > HTML > #document toDOMRange:range from 3 of #text > DIV > BODY > HTML > #document to 3 of #text > DIV > BODY > HTML > #document affinity:NSSelectionAffinityDownstream stillSelecting:FALSE
+EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
+EDITING DELEGATE: webViewDidChange:WebViewDidChangeNotification
+EDITING DELEGATE: shouldChangeSelectedDOMRange:range from 3 of #text > DIV > BODY > HTML > #document to 3 of #text > DIV > BODY > HTML > #document toDOMRange:range from 4 of #text > DIV > BODY > HTML > #document to 4 of #text > DIV > BODY > HTML > #document affinity:NSSelectionAffinityDownstream stillSelecting:FALSE
 EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
 EDITING DELEGATE: webViewDidChange:WebViewDidChangeNotification
 EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
-EDITING DELEGATE: shouldChangeSelectedDOMRange:range from 2 of #text > DIV > BODY > HTML > #document to 3 of #text > DIV > BODY > HTML > #document toDOMRange:range from 3 of #text > DIV > BODY > HTML > #document to 3 of #text > DIV > BODY > HTML > #document affinity:NSSelectionAffinityDownstream stillSelecting:FALSE
+EDITING DELEGATE: shouldChangeSelectedDOMRange:range from 3 of #text > DIV > BODY > HTML > #document to 3 of #text > DIV > BODY > HTML > #document toDOMRange:range from 5 of #text > DIV > BODY > HTML > #document to 5 of #text > DIV > BODY > HTML > #document affinity:NSSelectionAffinityDownstream stillSelecting:FALSE
 EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
 EDITING DELEGATE: webViewDidChange:WebViewDidChangeNotification
-EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
-EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
-EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
-EDITING DELEGATE: shouldChangeSelectedDOMRange:range from 3 of #text > DIV > BODY > HTML > #document to 4 of #text > DIV > BODY > HTML > #document toDOMRange:range from 4 of #text > DIV > BODY > HTML > #document to 4 of #text > DIV > BODY > HTML > #document affinity:NSSelectionAffinityDownstream stillSelecting:FALSE
+EDITING DELEGATE: shouldChangeSelectedDOMRange:range from 5 of #text > DIV > BODY > HTML > #document to 5 of #text > DIV > BODY > HTML > #document toDOMRange:range from 6 of #text > DIV > BODY > HTML > #document to 6 of #text > DIV > BODY > HTML > #document affinity:NSSelectionAffinityDownstream stillSelecting:FALSE
 EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
 EDITING DELEGATE: webViewDidChange:WebViewDidChangeNotification
-EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
-EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
-EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
-EDITING DELEGATE: shouldChangeSelectedDOMRange:range from 4 of #text > DIV > BODY > HTML > #document to 5 of #text > DIV > BODY > HTML > #document toDOMRange:range from 5 of #text > DIV > BODY > HTML > #document to 5 of #text > DIV > BODY > HTML > #document affinity:NSSelectionAffinityDownstream stillSelecting:FALSE
+EDITING DELEGATE: shouldChangeSelectedDOMRange:range from 6 of #text > DIV > BODY > HTML > #document to 6 of #text > DIV > BODY > HTML > #document toDOMRange:range from 7 of #text > DIV > BODY > HTML > #document to 7 of #text > DIV > BODY > HTML > #document affinity:NSSelectionAffinityDownstream stillSelecting:FALSE
 EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
 EDITING DELEGATE: webViewDidChange:WebViewDidChangeNotification
-EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
-EDITING DELEGATE: shouldChangeSelectedDOMRange:range from 5 of #text > DIV > BODY > HTML > #document to 6 of #text > DIV > BODY > HTML > #document toDOMRange:range from 6 of #text > DIV > BODY > HTML > #document to 6 of #text > DIV > BODY > HTML > #document affinity:NSSelectionAffinityDownstream stillSelecting:FALSE
+EDITING DELEGATE: shouldChangeSelectedDOMRange:range from 7 of #text > DIV > BODY > HTML > #document to 7 of #text > DIV > BODY > HTML > #document toDOMRange:range from 8 of #text > DIV > BODY > HTML > #document to 8 of #text > DIV > BODY > HTML > #document affinity:NSSelectionAffinityDownstream stillSelecting:FALSE
 EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
 EDITING DELEGATE: webViewDidChange:WebViewDidChangeNotification
-EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
-EDITING DELEGATE: shouldChangeSelectedDOMRange:range from 6 of #text > DIV > BODY > HTML > #document to 7 of #text > DIV > BODY > HTML > #document toDOMRange:range from 7 of #text > DIV > BODY > HTML > #document to 7 of #text > DIV > BODY > HTML > #document affinity:NSSelectionAffinityDownstream stillSelecting:FALSE
+EDITING DELEGATE: shouldChangeSelectedDOMRange:range from 8 of #text > DIV > BODY > HTML > #document to 8 of #text > DIV > BODY > HTML > #document toDOMRange:range from 9 of #text > DIV > BODY > HTML > #document to 9 of #text > DIV > BODY > HTML > #document affinity:NSSelectionAffinityDownstream stillSelecting:FALSE
 EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
 EDITING DELEGATE: webViewDidChange:WebViewDidChangeNotification
-EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
-EDITING DELEGATE: shouldChangeSelectedDOMRange:range from 7 of #text > DIV > BODY > HTML > #document to 8 of #text > DIV > BODY > HTML > #document toDOMRange:range from 8 of #text > DIV > BODY > HTML > #document to 8 of #text > DIV > BODY > HTML > #document affinity:NSSelectionAffinityDownstream stillSelecting:FALSE
+EDITING DELEGATE: shouldChangeSelectedDOMRange:range from 9 of #text > DIV > BODY > HTML > #document to 9 of #text > DIV > BODY > HTML > #document toDOMRange:range from 10 of #text > DIV > BODY > HTML > #document to 10 of #text > DIV > BODY > HTML > #document affinity:NSSelectionAffinityDownstream stillSelecting:FALSE
 EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
 EDITING DELEGATE: webViewDidChange:WebViewDidChangeNotification
-EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
-EDITING DELEGATE: shouldChangeSelectedDOMRange:range from 8 of #text > DIV > BODY > HTML > #document to 9 of #text > DIV > BODY > HTML > #document toDOMRange:range from 9 of #text > DIV > BODY > HTML > #document to 9 of #text > DIV > BODY > HTML > #document affinity:NSSelectionAffinityDownstream stillSelecting:FALSE
+EDITING DELEGATE: shouldChangeSelectedDOMRange:range from 10 of #text > DIV > BODY > HTML > #document to 10 of #text > DIV > BODY > HTML > #document toDOMRange:range from 11 of #text > DIV > BODY > HTML > #document to 11 of #text > DIV > BODY > HTML > #document affinity:NSSelectionAffinityDownstream stillSelecting:FALSE
 EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
 EDITING DELEGATE: webViewDidChange:WebViewDidChangeNotification
-EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
-EDITING DELEGATE: shouldChangeSelectedDOMRange:range from 9 of #text > DIV > BODY > HTML > #document to 10 of #text > DIV > BODY > HTML > #document toDOMRange:range from 10 of #text > DIV > BODY > HTML > #document to 10 of #text > DIV > BODY > HTML > #document affinity:NSSelectionAffinityDownstream stillSelecting:FALSE
+EDITING DELEGATE: shouldChangeSelectedDOMRange:range from 11 of #text > DIV > BODY > HTML > #document to 11 of #text > DIV > BODY > HTML > #document toDOMRange:range from 12 of #text > DIV > BODY > HTML > #document to 12 of #text > DIV > BODY > HTML > #document affinity:NSSelectionAffinityDownstream stillSelecting:FALSE
 EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
 EDITING DELEGATE: webViewDidChange:WebViewDidChangeNotification
-EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
-EDITING DELEGATE: shouldChangeSelectedDOMRange:range from 10 of #text > DIV > BODY > HTML > #document to 11 of #text > DIV > BODY > HTML > #document toDOMRange:range from 11 of #text > DIV > BODY > HTML > #document to 11 of #text > DIV > BODY > HTML > #document affinity:NSSelectionAffinityDownstream stillSelecting:FALSE
+EDITING DELEGATE: shouldChangeSelectedDOMRange:range from 12 of #text > DIV > BODY > HTML > #document to 12 of #text > DIV > BODY > HTML > #document toDOMRange:range from 13 of #text > DIV > BODY > HTML > #document to 13 of #text > DIV > BODY > HTML > #document affinity:NSSelectionAffinityDownstream stillSelecting:FALSE
 EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
 EDITING DELEGATE: webViewDidChange:WebViewDidChangeNotification
-EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
-EDITING DELEGATE: shouldChangeSelectedDOMRange:range from 11 of #text > DIV > BODY > HTML > #document to 12 of #text > DIV > BODY > HTML > #document toDOMRange:range from 12 of #text > DIV > BODY > HTML > #document to 12 of #text > DIV > BODY > HTML > #document affinity:NSSelectionAffinityDownstream stillSelecting:FALSE
+EDITING DELEGATE: shouldChangeSelectedDOMRange:range from 13 of #text > DIV > BODY > HTML > #document to 13 of #text > DIV > BODY > HTML > #document toDOMRange:range from 14 of #text > DIV > BODY > HTML > #document to 14 of #text > DIV > BODY > HTML > #document affinity:NSSelectionAffinityDownstream stillSelecting:FALSE
 EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
 EDITING DELEGATE: webViewDidChange:WebViewDidChangeNotification
-EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
-EDITING DELEGATE: shouldChangeSelectedDOMRange:range from 12 of #text > DIV > BODY > HTML > #document to 13 of #text > DIV > BODY > HTML > #document toDOMRange:range from 13 of #text > DIV > BODY > HTML > #document to 13 of #text > DIV > BODY > HTML > #document affinity:NSSelectionAffinityDownstream stillSelecting:FALSE
-EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
-EDITING DELEGATE: webViewDidChange:WebViewDidChangeNotification
-EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
-EDITING DELEGATE: shouldChangeSelectedDOMRange:range from 13 of #text > DIV > BODY > HTML > #document to 14 of #text > DIV > BODY > HTML > #document toDOMRange:range from 14 of #text > DIV > BODY > HTML > #document to 14 of #text > DIV > BODY > HTML > #document affinity:NSSelectionAffinityDownstream stillSelecting:FALSE
-EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
-EDITING DELEGATE: webViewDidChange:WebViewDidChangeNotification
-EDITING DELEGATE: shouldChangeSelectedDOMRange:range from 14 of #text > DIV > BODY > HTML > #document to 14 of #text > DIV > BODY > HTML > #document toDOMRange:range from 4 of #text > DIV > BODY > HTML > #document to 13 of #text > DIV > BODY > HTML > #document affinity:NSSelectionAffinityDownstream stillSelecting:FALSE
-EDITING DELEGATE: shouldInsertText:notational replacingDOMRange:range from 4 of #text > DIV > BODY > HTML > #document to 13 of #text > DIV > BODY > HTML > #document givenAction:WebViewInsertActionTyped
-EDITING DELEGATE: shouldChangeSelectedDOMRange:range from 14 of #text > DIV > BODY > HTML > #document to 14 of #text > DIV > BODY > HTML > #document toDOMRange:range from 4 of #text > DIV > BODY > HTML > #document to 13 of #text > DIV > BODY > HTML > #document affinity:NSSelectionAffinityDownstream stillSelecting:FALSE
-EDITING DELEGATE: shouldChangeSelectedDOMRange:range from 14 of #text > DIV > BODY > HTML > #document to 14 of #text > DIV > BODY > HTML > #document toDOMRange:range from 4 of #text > DIV > BODY > HTML > #document to 13 of #text > DIV > BODY > HTML > #document affinity:NSSelectionAffinityDownstream stillSelecting:FALSE
-EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
-EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
-EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
-EDITING DELEGATE: shouldChangeSelectedDOMRange:range from 4 of #text > DIV > BODY > HTML > #document to 14 of #text > DIV > BODY > HTML > #document toDOMRange:range from 14 of #text > DIV > BODY > HTML > #document to 14 of #text > DIV > BODY > HTML > #document affinity:NSSelectionAffinityDownstream stillSelecting:FALSE
-EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
-EDITING DELEGATE: webViewDidChange:WebViewDidChangeNotification
-EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
-EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
-EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
-EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
-EDITING DELEGATE: shouldChangeSelectedDOMRange:range from 15 of #text > DIV > BODY > HTML > #document to 16 of #text > DIV > BODY > HTML > #document toDOMRange:range from 16 of #text > DIV > BODY > HTML > #document to 16 of #text > DIV > BODY > HTML > #document affinity:NSSelectionAffinityDownstream stillSelecting:FALSE
+EDITING DELEGATE: shouldChangeSelectedDOMRange:range from 14 of #text > DIV > BODY > HTML > #document to 14 of #text > DIV > BODY > HTML > #document toDOMRange:range from 15 of #text > DIV > BODY > HTML > #document to 15 of #text > DIV > BODY > HTML > #document affinity:NSSelectionAffinityDownstream stillSelecting:FALSE
 EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
 EDITING DELEGATE: webViewDidChange:WebViewDidChangeNotification
 layer at (0,0) size 800x600
@@ -92,7 +62,7 @@
           text run at (0,18) width 740: "spelling of 'notationl' several times, the spell checker will not provide 'notational' as a suggestion anymore. To fix this,"
           text run at (0,36) width 236: "remove all files in ~/Library/Spelling."
       RenderBlock {DIV} at (0,122) size 784x56 [border: (2px solid #FF0000)]
-        RenderText {#text} at (14,14) size 146x28
-          text run at (14,14) width 146: "the notational, "
+        RenderText {#text} at (14,14) size 135x28
+          text run at (14,14) width 135: "the notationl, "
         RenderInline {SPAN} at (0,0) size 0x28
-caret: position 16 of child 0 {#text} of child 5 {DIV} of body
+caret: position 15 of child 0 {#text} of child 5 {DIV} of body

[Radar WebKit Bug Importer]

<rdar://problem/12207679>

[Jessie Berlin]

I am going to go ahead and move the current mac results to mac-lion and land the ML text results in mac in order to get the bots greener.

[Jia Pu]

Created attachment 162357 [details]
patch (v1)

[Jessie Berlin]

Comment on attachment 162357 [details]
patch (v1)

View in context: https://bugs.webkit.org/attachment.cgi?id=162357&action=review

> Tools/ChangeLog:12
> +        (resetDefaultsToConsistentValues):

Why do you only need to make changes to DumpRenderTree? Are these tests not being run for WK2 (WebKitTestRunner)?

> LayoutTests/ChangeLog:13
> +        * platform/mac/editing/spelling/removing-underline-after-accepting-autocorrection-using-punctuation.html:

It looks to me like there are other tests in platform/mac with the disclaimers ("this test can fail due to user specific spell checking data") that you removed from these tests. Why aren't you making similar changes to all of them (e.g. autocorrection-at-beginning-of-word-1.html, autocorrection-at-beginning-of-word-2.html, autocorrection-delete.html, autocorrection-removing-underline-after-paste.html, autocorrection-simple.html, click-autocorrected-word.html, delete-autocorrected-word-1.html, etc)?

> LayoutTests/platform/mac/editing/spelling/removing-underline-after-accepting-autocorrection-using-punctuation-expected.txt:73
> +caret: position 16 of child 0 {#text} of child 3 {DIV} of body

What about the mac-lion results for this? Do they need to be updated? If they are identical to these new results, please remove the mac-lion results.

[Jia Pu]

(In reply to comment #4)
> (From update of attachment 162357 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=162357&action=review
> 
> > Tools/ChangeLog:12
> > +        (resetDefaultsToConsistentValues):
> 
> Why do you only need to make changes to DumpRenderTree? Are these tests not being run for WK2 (WebKitTestRunner)?]

When I execute run-webkit-test script, it seems only use DumpRenderTree. I can certainly make similar change to WebKitTestRunner though.

> 
> > LayoutTests/ChangeLog:13
> > +        * platform/mac/editing/spelling/removing-underline-after-accepting-autocorrection-using-punctuation.html:
> 
> It looks to me like there are other tests in platform/mac with the disclaimers ("this test can fail due to user specific spell checking data") that you removed from these tests. Why aren't you making similar changes to all of them (e.g. autocorrection-at-beginning-of-word-1.html, autocorrection-at-beginning-of-word-2.html, autocorrection-delete.html, autocorrection-removing-underline-after-paste.html, autocorrection-simple.html, click-autocorrected-word.html, delete-autocorrected-word-1.html, etc)?

Yes, I realize that. I'm thinking to get this patch in first, then adjust all remaining test cases. But I'm fine with changes all tests in one go.

> 
> > LayoutTests/platform/mac/editing/spelling/removing-underline-after-accepting-autocorrection-using-punctuation-expected.txt:73
> > +caret: position 16 of child 0 {#text} of child 3 {DIV} of body
> 
> What about the mac-lion results for this? Do they need to be updated? If they are identical to these new results, please remove the mac-lion results.

Will check.

[Jessie Berlin]

(In reply to comment #5)
> (In reply to comment #4)
> > (From update of attachment 162357 [details] [details])
> > View in context: https://bugs.webkit.org/attachment.cgi?id=162357&action=review
> > 
> > > Tools/ChangeLog:12
> > > +        (resetDefaultsToConsistentValues):
> > 
> > Why do you only need to make changes to DumpRenderTree? Are these tests not being run for WK2 (WebKitTestRunner)?]
> 
> When I execute run-webkit-test script, it seems only use DumpRenderTree. I can certainly make similar change to WebKitTestRunner though.

run-webkit-tests -2

runs the WebKit2 tests.

[Jessie Berlin]

Comment on attachment 162357 [details]
patch (v1)

Please change all the tests in one go and make sure you check the mac-lion situation. I am setting r- to make it clear to other reviewers that this isn't still awaiting review.

[Jia Pu]

(In reply to comment #6)
> (In reply to comment #5)
> > (In reply to comment #4)
> > > (From update of attachment 162357 [details] [details] [details])
> > > View in context: https://bugs.webkit.org/attachment.cgi?id=162357&action=review
> > > 
> > > > Tools/ChangeLog:12
> > > > +        (resetDefaultsToConsistentValues):
> > > 
> > > Why do you only need to make changes to DumpRenderTree? Are these tests not being run for WK2 (WebKitTestRunner)?]
> > 
> > When I execute run-webkit-test script, it seems only use DumpRenderTree. I can certainly make similar change to WebKitTestRunner though.
> 
> run-webkit-tests -2
> 
> runs the WebKit2 tests.

I looked into WebKit2 scenario. It seems autocorrection is carried out at all for WK2. When I set a break point at TypingCommand::insertText(const String&, bool) in LLDB, then ran following command:

run /Volumes/Data/git_workspace/WebKit/OpenSource/LayoutTests/platform/mac/editing/spelling/autocorrection-simple.html

The break point doesn't get triggered. Did I miss something or is the execution of editing in layout test indeed different from what happens when using WK2 in Safari?

[Jessie Berlin]

(In reply to comment #8)
> (In reply to comment #6)
> > (In reply to comment #5)
> > > (In reply to comment #4)
> > > > (From update of attachment 162357 [details] [details] [details] [details])
> > > > View in context: https://bugs.webkit.org/attachment.cgi?id=162357&action=review
> > > > 
> > > > > Tools/ChangeLog:12
> > > > > +        (resetDefaultsToConsistentValues):
> > > > 
> > > > Why do you only need to make changes to DumpRenderTree? Are these tests not being run for WK2 (WebKitTestRunner)?]
> > > 
> > > When I execute run-webkit-test script, it seems only use DumpRenderTree. I can certainly make similar change to WebKitTestRunner though.
> > 
> > run-webkit-tests -2
> > 
> > runs the WebKit2 tests.
> 
> I looked into WebKit2 scenario. It seems autocorrection is carried out at all for WK2. When I set a break point at TypingCommand::insertText(const String&, bool) in LLDB, then ran following command:
> 
> run /Volumes/Data/git_workspace/WebKit/OpenSource/LayoutTests/platform/mac/editing/spelling/autocorrection-simple.html
> 
> The break point doesn't get triggered. Did I miss something or is the execution of editing in layout test indeed different from what happens when using WK2 in Safari?

Were you attached to the Web Process when debugging?

[Ryosuke Niwa]

This was clogging the commit queue because most of bots used as commit queues corrects "notation" :( We need to fix this bug ASAP.

[Ryosuke Niwa]

I've reverted the Jessie's rebaseline in http://trac.webkit.org/changeset/138345 in order to unclog the commit queue. We probably need to add [ Pass Failure ] expectation if we can't fix this bug soon.

[Ryosuke Niwa]

I've made the equivalent change in WTR but it doesn't work. It seems as if WTR isn't enabling continuous spellchecking:

Index: Tools/WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm
===================================================================
--- Tools/WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm	(revision 138343)
+++ Tools/WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm	(working copy)
@@ -47,6 +47,9 @@
         [NSNumber numberWithBool:NO],     @"NSOverlayScrollersEnabled",
         @"Always",                        @"AppleShowScrollBars",
         [NSArray arrayWithObject:@"en"],  @"AppleLanguages",
+#if __MAC_OS_X_VERSION_MIN_REQUIRED >= 1070
+        [NSDictionary dictionaryWithObjectsAndKeys:@"notational", @"notationl", nil], @"NSTestCorrectionDictionary",
+#endif
         nil];
 
     [[NSUserDefaults standardUserDefaults] setVolatileDomain:dict forName:NSArgumentDomain];
Index: Tools/DumpRenderTree/mac/DumpRenderTree.mm
===================================================================
--- Tools/DumpRenderTree/mac/DumpRenderTree.mm	(revision 138343)
+++ Tools/DumpRenderTree/mac/DumpRenderTree.mm	(working copy)
@@ -587,6 +587,10 @@
     [defaults setBool:YES forKey:WebKitFullScreenEnabledPreferenceKey];
     [defaults setBool:YES forKey:@"UseWebKitWebInspector"];
 
+#if __MAC_OS_X_VERSION_MIN_REQUIRED >= 1070
+    [defaults setObject:[NSDictionary dictionaryWithObjectsAndKeys:@"notational", @"notationl", nil] forKey:@"NSTestCorrectionDictionary"];
+#endif
+
     // Scrollbars are drawn either using AppKit (which uses NSUserDefaults) or using HIToolbox (which uses CFPreferences / kCFPreferencesAnyApplication / kCFPreferencesCurrentUser / kCFPreferencesAnyHost)
     [defaults setObject:@"DoubleMax" forKey:@"AppleScrollBarVariant"];
     RetainPtr<CFTypeRef> initialValue = CFPreferencesCopyValue(CFSTR("AppleScrollBarVariant"), kCFPreferencesAnyApplication, kCFPreferencesCurrentUser, kCFPreferencesAnyHost);


Since most of spellchecking tests are disabled on WTR anyway, we should probably fix this for DRT and investigate WTR issue on a separate bug.

[Ryosuke Niwa]

Filed https://bugs.webkit.org/show_bug.cgi?id=105616 to track the WebKit2 issue.

[Ryosuke Niwa]

Created attachment 180482 [details]
Fixes the bug at least for WebKit1

[Ryosuke Niwa]

Created attachment 180483 [details]
Fixed a typo in the change log

[Ryosuke Niwa]

Committed r138405: <http://trac.webkit.org/changeset/138405>