Bug 95470 – [CG] ImageCG.cpp contains a mix of Image and BitmapImage functions

• Status: RESOLVED
• Resolution: FIXED
• Component: Platform

[CG] ImageCG.cpp contains a mix of Image and BitmapImage functions

Created attachment 161498 [details]
Split BitmapImage functions out into BitmapImageCG.cpp

[WebKit Review Bot]

Attachment 161498 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebCore/platform/graphics/cg/BitmapImageCG.cpp:120:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
Source/WebCore/platform/graphics/cg/BitmapImageCG.cpp:152:  Use 0 instead of NULL.  [readability/null] [5]
Total errors found: 2 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Build Bot]

Comment on attachment 161498 [details]
Split BitmapImage functions out into BitmapImageCG.cpp

Attachment 161498 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/13690775

Created attachment 161515 [details]
Split BitmapImage functions out into BitmapImageCG.cpp

[WebKit Review Bot]

Attachment 161515 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebCore/platform/graphics/cg/BitmapImageCG.cpp:120:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
Source/WebCore/platform/graphics/cg/BitmapImageCG.cpp:152:  Use 0 instead of NULL.  [readability/null] [5]
Total errors found: 2 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Created attachment 161516 [details]
Split BitmapImage functions out into BitmapImageCG.cpp

[WebKit Review Bot]

Attachment 161516 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebCore/platform/graphics/cg/BitmapImageCG.cpp:120:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
Source/WebCore/platform/graphics/cg/BitmapImageCG.cpp:152:  Use 0 instead of NULL.  [readability/null] [5]
Total errors found: 2 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Tim Horton]

Comment on attachment 161516 [details]
Split BitmapImage functions out into BitmapImageCG.cpp

View in context: https://bugs.webkit.org/attachment.cgi?id=161516&action=review

> Source/WebCore/ChangeLog:144
> +>>>>>>> .r127158

Hmm.

(In reply to comment #8)
> (From update of attachment 161516 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=161516&action=review
> 
> > Source/WebCore/ChangeLog:144
> > +>>>>>>> .r127158
> 
> Hmm.

Noted.

Fixed in <http://trac.webkit.org/r127170>.

[Daniel Bates]

Comment on attachment 161498 [details]
Split BitmapImage functions out into BitmapImageCG.cpp

View in context: https://bugs.webkit.org/attachment.cgi?id=161498&action=review

I know that this patch was already reviewed and committed. I noticed some minor nits in the license block in the file WebCore/platform/graphics/cg/BitmapImageCG.cpp.

> Source/WebCore/platform/graphics/cg/BitmapImageCG.cpp:2
> + * Copyright (C) 2004, 2005, 2006 Apple Inc. All rights reserved.

Nit: Shouldn't we update the copyright line?

> Source/WebCore/platform/graphics/cg/BitmapImageCG.cpp:13
> + * THIS SOFTWARE IS PROVIDED BY APPLE COMPUTER, INC. ``AS IS'' AND ANY

Nit: APPLE COMPUTER, INC => APPLE INC.

> Source/WebCore/platform/graphics/cg/BitmapImageCG.cpp:16
> + * PURPOSE ARE DISCLAIMED.  IN NO EVENT SHALL APPLE COMPUTER, INC. OR

Ditto.

We could update the license blocks, though we normally do this when making changes to the code, not when just moving existing code around.