Bug 95469 - [BlackBerry] Implement IncrementalSweeper for PLATFORM(BLACKBERRY)
Summary: [BlackBerry] Implement IncrementalSweeper for PLATFORM(BLACKBERRY)
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-08-30 09:36 PDT by Yong Li
Modified: 2012-08-30 13:50 PDT (History)
3 users (show)

See Also:


Attachments
the patch (3.47 KB, patch)
2012-08-30 09:43 PDT, Yong Li
no flags Details | Formatted Diff | Diff
the patch (3.61 KB, patch)
2012-08-30 09:52 PDT, Yong Li
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yong Li 2012-08-30 09:36:34 PDT
as we have the HeapTimer implemented
Comment 1 Yong Li 2012-08-30 09:43:20 PDT
Created attachment 161496 [details]
the patch

It shares most code with USE(CF). But I have to change CFTimeInterval to double. Geoffrey, is that OK?
Comment 2 Yong Li 2012-08-30 09:52:55 PDT
Created attachment 161500 [details]
the patch
Comment 3 Rob Buis 2012-08-30 10:16:20 PDT
Comment on attachment 161500 [details]
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=161500&action=review

> Source/JavaScriptCore/heap/IncrementalSweeper.cpp:106
> +        double elapsedTime = WTF::monotonicallyIncreasingTime() - sweepBeginTime;

This patch looks good to me, Yong said he took double over CFTimeInterval here since all methods used return double's. Maybe some Apple folks can comment whether CFTimeInterval usage is absolutely needed here?
Comment 4 Rob Buis 2012-08-30 13:36:46 PDT
Comment on attachment 161500 [details]
the patch

LGTM.
Comment 5 WebKit Review Bot 2012-08-30 13:50:16 PDT
Comment on attachment 161500 [details]
the patch

Clearing flags on attachment: 161500

Committed r127185: <http://trac.webkit.org/changeset/127185>
Comment 6 WebKit Review Bot 2012-08-30 13:50:19 PDT
All reviewed patches have been landed.  Closing bug.