Bug 95459 - Web Inspector: sort object properties when dumping them in tests
Summary: Web Inspector: sort object properties when dumping them in tests
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Pavel Feldman
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-08-30 08:26 PDT by Pavel Feldman
Modified: 2012-08-31 09:03 PDT (History)
11 users (show)

See Also:

Attachments
Patch (105.85 KB, patch)
2012-08-30 08:53 PDT, Pavel Feldman 		vsevik: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Feldman 2012-08-30 08:26:18 PDT 
Otherwise tests might become flaky.
Comment 1 Pavel Feldman 2012-08-30 08:53:09 PDT 
Created attachment 161483 [details]
Patch
Comment 2 Pavel Feldman 2012-08-30 08:58:30 PDT 
Committed r127147: <http://trac.webkit.org/changeset/127147>
Comment 3 Jessie Berlin 2012-08-30 17:40:11 PDT 
This caused the inspector/timeline/timeline-paint.html test to start failing on the Mac bots:

http://build.webkit.org/results/Apple%20Lion%20Debug%20WK1%20(Tests)/r127149%20(2381)/inspector/timeline/timeline-paint-pretty-diff.html

I think the checked in value of timeline-paint is wrong because, sorting by property name, the mac results are correct.

--- /Volumes/Data/slave/lion-debug-tests-wk1/build/layout-test-results/inspector/timeline/timeline-paint-expected.txt
+++ /Volumes/Data/slave/lion-debug-tests-wk1/build/layout-test-results/inspector/timeline/timeline-paint-actual.txt
@@ -5,15 +5,15 @@
     children : <object>
     counters : <object>
     data : {
+        height : <number>
+        width : <number>
         x : 0
         y : 0
-        width : <number>
-        height : <number>
     }
     endTime : <number>
     frameId : <string>
+    stackTrace : <object>
     startTime : <number>
-    stackTrace : <object>
     totalHeapSize : <number>
     type : "Paint"
     usedHeapSize : <number>

Unless I hear otherwise, I am going to make that change to the timeline-paint expected results.
Comment 4 Jessie Berlin 2012-08-31 09:03:32 PDT 
Looks like Pavel Feldman fixed half of the results in http://trac.webkit.org/changeset/127164. I fixed the other half in http://trac.webkit.org/changeset/127271.