Bug 95459 – Web Inspector: sort object properties when dumping them in tests

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Pavel Feldman]

Otherwise tests might become flaky.

[Pavel Feldman]

Created attachment 161483 [details]
Patch

[Pavel Feldman]

Committed r127147: <http://trac.webkit.org/changeset/127147>

[Jessie Berlin]

This caused the inspector/timeline/timeline-paint.html test to start failing on the Mac bots:

http://build.webkit.org/results/Apple%20Lion%20Debug%20WK1%20(Tests)/r127149%20(2381)/inspector/timeline/timeline-paint-pretty-diff.html

I think the checked in value of timeline-paint is wrong because, sorting by property name, the mac results are correct.

--- /Volumes/Data/slave/lion-debug-tests-wk1/build/layout-test-results/inspector/timeline/timeline-paint-expected.txt
+++ /Volumes/Data/slave/lion-debug-tests-wk1/build/layout-test-results/inspector/timeline/timeline-paint-actual.txt
@@ -5,15 +5,15 @@
     children : <object>
     counters : <object>
     data : {
+        height : <number>
+        width : <number>
         x : 0
         y : 0
-        width : <number>
-        height : <number>
     }
     endTime : <number>
     frameId : <string>
+    stackTrace : <object>
     startTime : <number>
-    stackTrace : <object>
     totalHeapSize : <number>
     type : "Paint"
     usedHeapSize : <number>

Unless I hear otherwise, I am going to make that change to the timeline-paint expected results.

[Jessie Berlin]

Looks like Pavel Feldman fixed half of the results in http://trac.webkit.org/changeset/127164. I fixed the other half in http://trac.webkit.org/changeset/127271.