Bug 95456 - Web Inspector: render box model elements and grid on inspector overlay
Summary: Web Inspector: render box model elements and grid on inspector overlay
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Pavel Feldman
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-08-30 07:12 PDT by Pavel Feldman
Modified: 2012-08-31 02:35 PDT (History)
12 users (show)

See Also:

Attachments
[IMAGE] with patch applied (119.57 KB, image/png)
2012-08-30 07:27 PDT, Pavel Feldman 		no flags Details
Patch (46.02 KB, patch)
2012-08-30 07:27 PDT, Pavel Feldman 		no flags Details | Formatted Diff | Diff
Patch (46.47 KB, patch)
2012-08-30 08:11 PDT, Pavel Feldman 		no flags Details | Formatted Diff | Diff
Patch (46.51 KB, patch)
2012-08-30 08:56 PDT, Pavel Feldman 		no flags Details | Formatted Diff | Diff
Patch (47.53 KB, patch)
2012-08-31 01:36 PDT, Pavel Feldman 		no flags Details | Formatted Diff | Diff
Patch (47.55 KB, patch)
2012-08-31 01:54 PDT, Pavel Feldman 		vsevik: review+
Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Feldman 2012-08-30 07:12:53 PDT 
This change migrates native rendering for box model to the InspectorOverlay.
Comment 1 Pavel Feldman 2012-08-30 07:27:10 PDT 
Created attachment 161464 [details]
[IMAGE] with patch applied
Comment 2 Pavel Feldman 2012-08-30 07:27:35 PDT 
Created attachment 161465 [details]
Patch
Comment 3 Peter Beverloo (cr-android ews) 2012-08-30 07:41:46 PDT 
Comment on attachment 161465 [details]
Patch

Attachment 161465 [details] did not pass cr-android-ews (chromium-android):
Output: http://queues.webkit.org/results/13681701
Comment 4 Build Bot 2012-08-30 07:44:29 PDT 
Comment on attachment 161465 [details]
Patch

Attachment 161465 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/13684716
Comment 5 Pavel Feldman 2012-08-30 08:11:49 PDT 
Created attachment 161473 [details]
Patch
Comment 6 Build Bot 2012-08-30 08:26:25 PDT 
Comment on attachment 161473 [details]
Patch

Attachment 161473 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/13688768
Comment 7 Peter Beverloo (cr-android ews) 2012-08-30 08:34:42 PDT 
Comment on attachment 161473 [details]
Patch

Attachment 161473 [details] did not pass cr-android-ews (chromium-android):
Output: http://queues.webkit.org/results/13684726
Comment 8 Pavel Feldman 2012-08-30 08:56:19 PDT 
Created attachment 161484 [details]
Patch
Comment 9 Peter Beverloo (cr-android ews) 2012-08-30 09:15:39 PDT 
Comment on attachment 161484 [details]
Patch

Attachment 161484 [details] did not pass cr-android-ews (chromium-android):
Output: http://queues.webkit.org/results/13688779
Comment 10 Vsevolod Vlasov 2012-08-31 01:29:00 PDT 
Comment on attachment 161484 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=161484&action=review

> Source/WebCore/inspector/InspectorOverlay.cpp:48
> +#include "RenderView.h"

Not needed ?

> Source/WebCore/inspector/InspectorOverlay.cpp:393
>  {

Maybe 
if (m_pausedInDebuggerMessage.isEmpty())
    return
?

> Source/WebCore/inspector/InspectorOverlay.cpp:425
> +#if OS(WINDOWS)

Move this checks in InspectorOverlayPage.html ?

> Source/WebCore/inspector/InspectorOverlay.cpp:426
> +overlaySettings->setDefaultFontSize(12);

indent

> Source/WebCore/inspector/InspectorOverlay.h:34
> +#include "InspectorValues.h"

is that needed?

> Source/WebCore/inspector/InspectorOverlayPage.html:84
> +function takeLast(array)

array.pop()
Comment 11 Pavel Feldman 2012-08-31 01:36:16 PDT 
Created attachment 161637 [details]
Patch
Comment 12 Pavel Feldman 2012-08-31 01:36:58 PDT 
> Not needed ?
> 

Done.

> Maybe 
> if (m_pausedInDebuggerMessage.isEmpty())
>     return

Done.

> > Source/WebCore/inspector/InspectorOverlay.cpp:425
> > +#if OS(WINDOWS)
> 
> Move this checks in InspectorOverlayPage.html ?

Done.

> 
> > Source/WebCore/inspector/InspectorOverlay.cpp:426
> > +overlaySettings->setDefaultFontSize(12);
> 
> indent

Done.

> 
> > Source/WebCore/inspector/InspectorOverlay.h:34
> > +#include "InspectorValues.h"
> 
> is that needed?

Done.

> 
> > Source/WebCore/inspector/InspectorOverlayPage.html:84
> > +function takeLast(array)
> 
> array.pop()
Comment 13 Peter Beverloo (cr-android ews) 2012-08-31 01:48:25 PDT 
Comment on attachment 161637 [details]
Patch

Attachment 161637 [details] did not pass cr-android-ews (chromium-android):
Output: http://queues.webkit.org/results/13722071
Comment 14 Pavel Feldman 2012-08-31 01:54:21 PDT 
Created attachment 161639 [details]
Patch
Comment 15 Pavel Feldman 2012-08-31 02:35:38 PDT 
Committed r127240: <http://trac.webkit.org/changeset/127240>