Bug 95447 - [BlackBerry] One shot drawing sync flag never cleared when there's no layers
Summary: [BlackBerry] One shot drawing sync flag never cleared when there's no layers
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Arvid Nilsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-08-30 05:01 PDT by Arvid Nilsson
Modified: 2012-08-30 08:06 PDT (History)
6 users (show)

See Also:

Attachments
Patch (2.58 KB, patch)
2012-08-30 05:22 PDT, Arvid Nilsson 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Arvid Nilsson 2012-08-30 05:01:01 PDT 
When we remove the layers, WebKit could tell us we need a one shot drawing sync to repaint the BackingStore with the content that was previously drawn by layers. We also sometimes set the one shot drawing sync flag manually.

We would bail from commit if there were no layers and not actually perform the osds, so it left the osds flag set forever and the situation prevails, because nobody will ever clear the osds flag.

No commit means no blit, and the result of regular rendering does not show up on screen.
Comment 1 Arvid Nilsson 2012-08-30 05:17:23 PDT 
PR 199866
Comment 2 Arvid Nilsson 2012-08-30 05:22:14 PDT 
Created attachment 161447 [details]
Patch
Comment 3 WebKit Review Bot 2012-08-30 08:06:25 PDT 
Comment on attachment 161447 [details]
Patch

Clearing flags on attachment: 161447

Committed r127141: <http://trac.webkit.org/changeset/127141>
Comment 4 WebKit Review Bot 2012-08-30 08:06:29 PDT 
All reviewed patches have been landed.  Closing bug.