Bug 95435 - [NRWT] Add support for recognizing arbitrary process names in crash lines
Summary: [NRWT] Add support for recognizing arbitrary process names in crash lines
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: jochen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-08-30 01:19 PDT by jochen
Modified: 2012-08-30 04:00 PDT (History)
4 users (show)

See Also:

Attachments
Patch (3.73 KB, patch)
2012-08-30 01:20 PDT, jochen 		no flags Details | Formatted Diff | Diff
Patch for landing (3.89 KB, patch)
2012-08-30 01:39 PDT, jochen 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description jochen 2012-08-30 01:19:46 PDT 
[NRWT] Add support for recognizing arbitrary process names in crash lines
Comment 1 jochen 2012-08-30 01:20:53 PDT 
Created attachment 161424 [details]
Patch
Comment 2 Adam Barth 2012-08-30 01:33:56 PDT 
Comment on attachment 161424 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=161424&action=review

> Tools/Scripts/webkitpy/layout_tests/port/driver.py:313
> +            m = re.match('#(?:CRASHED|PROCESS UNRESPONSIVE) - (\S+)', error_line)

Can we use a variable name that's more descriptive than "m" ?

> Tools/Scripts/webkitpy/layout_tests/port/driver.py:317
> +            if m:
> +                self._crashed_process_name = m.group(1)
> +            else:
> +                self._crashed_process_name = 'WebProcess'

This really wants to be a ternary expression.
Comment 3 jochen 2012-08-30 01:39:46 PDT 
Created attachment 161426 [details]
Patch for landing
Comment 4 WebKit Review Bot 2012-08-30 04:00:32 PDT 
Comment on attachment 161426 [details]
Patch for landing

Clearing flags on attachment: 161426

Committed r127122: <http://trac.webkit.org/changeset/127122>
Comment 5 WebKit Review Bot 2012-08-30 04:00:36 PDT 
All reviewed patches have been landed.  Closing bug.