RESOLVED FIXED95435
[NRWT] Add support for recognizing arbitrary process names in crash lines 
https://bugs.webkit.org/show_bug.cgi?id=95435
Summary [NRWT] Add support for recognizing arbitrary process names in crash lines
jochen
Reported 2012-08-30 01:19:46 PDT
[NRWT] Add support for recognizing arbitrary process names in crash lines
Attachments
Patch (3.73 KB, patch)
2012-08-30 01:20 PDT, jochen 		no flags
DetailsFormatted DiffDiff
Patch for landing (3.89 KB, patch)
2012-08-30 01:39 PDT, jochen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
jochen
Comment 1 2012-08-30 01:20:53 PDT
Created attachment 161424 [details] Patch
Adam Barth
Comment 2 2012-08-30 01:33:56 PDT
Comment on attachment 161424 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=161424&action=review > Tools/Scripts/webkitpy/layout_tests/port/driver.py:313 > + m = re.match('#(?:CRASHED|PROCESS UNRESPONSIVE) - (\S+)', error_line) Can we use a variable name that's more descriptive than "m" ? > Tools/Scripts/webkitpy/layout_tests/port/driver.py:317 > + if m: > + self._crashed_process_name = m.group(1) > + else: > + self._crashed_process_name = 'WebProcess' This really wants to be a ternary expression.
jochen
Comment 3 2012-08-30 01:39:46 PDT
Created attachment 161426 [details] Patch for landing
WebKit Review Bot
Comment 4 2012-08-30 04:00:32 PDT
Comment on attachment 161426 [details] Patch for landing Clearing flags on attachment: 161426 Committed r127122: <http://trac.webkit.org/changeset/127122>
WebKit Review Bot
Comment 5 2012-08-30 04:00:36 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.