Bug 95420 – Use ASCIILiteral for DEFINE_STATIC_LOCAL string

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Gyuyoung Kim]

As recommended by http://trac.webkit.org/wiki/EfficientStrings, WebKit needs to use ASCIILiteral for the string of DEFINE_STATIC_LOCAL.

[Gyuyoung Kim]

Created attachment 161400 [details]
Patch

[Gyuyoung Kim]

CC'ing Benjamin

[Benjamin Poulain]

Comment on attachment 161400 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=161400&action=review

r- because of the AtomicStrings.
My apologies about that, I should have documented it earlier.

It is very nice of you to update all the ports.

> Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp:240
> +    DEFINE_STATIC_LOCAL(AtomicString, Default, (ASCIILiteral("default")));
> +    DEFINE_STATIC_LOCAL(AtomicString, Url, (ASCIILiteral("url")));
> +    DEFINE_STATIC_LOCAL(AtomicString, Email, (ASIILiteral("email")));
> +    DEFINE_STATIC_LOCAL(AtomicString, Password, (ASCIILiteral("password")));
> +    DEFINE_STATIC_LOCAL(AtomicString, Web, (ASCIILiteral("web")));
> +    DEFINE_STATIC_LOCAL(AtomicString, Number, (ASCIILiteral("number")));
> +    DEFINE_STATIC_LOCAL(AtomicString, Symbol, (ASCIILiteral("symbol")));
> +    DEFINE_STATIC_LOCAL(AtomicString, Phone, (ASCIILiteral("phone")));
> +    DEFINE_STATIC_LOCAL(AtomicString, Pin, (ASCIILiteral("pin")));
> +    DEFINE_STATIC_LOCAL(AtomicString, Hex, (ASCIILiteral("hexadecimal")));

AtomicString should not use ASCIILiteral, I updated the Wiki this afternoon.
You should use the constructor with AtomicString::ConstructFromLiteral so that I can do more optimizations later for AtomicString.

> Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp:295
> +    DEFINE_STATIC_LOCAL(AtomicString, Default, (ASCIILiteral("default")));
> +    DEFINE_STATIC_LOCAL(AtomicString, Connect, (ASCIILiteral("connect")));
> +    DEFINE_STATIC_LOCAL(AtomicString, Done, (ASCIILiteral("done")));
> +    DEFINE_STATIC_LOCAL(AtomicString, Go, (ASCIILiteral("go")));
> +    DEFINE_STATIC_LOCAL(AtomicString, Join, (ASCIILiteral("join")));
> +    DEFINE_STATIC_LOCAL(AtomicString, Next, (ASCIILiteral("next")));
> +    DEFINE_STATIC_LOCAL(AtomicString, Search, (ASCIILiteral("search")));
> +    DEFINE_STATIC_LOCAL(AtomicString, Send, (ASCIILiteral("send")));
> +    DEFINE_STATIC_LOCAL(AtomicString, Submit, (ASCIILiteral("submit")));

Ditto.

> Source/WebKit/chromium/src/ContextFeaturesClientImpl.cpp:99
> +    DEFINE_STATIC_LOCAL(AtomicString, name, (ASCIILiteral("ContextFeaturesCache")));

Ditto.

> Source/WebKit/gtk/webkit/webkitwebsettings.cpp:137
> -    DEFINE_STATIC_LOCAL(const String, uaPlatform, (String("")));
> +    DEFINE_STATIC_LOCAL(const String, uaPlatform, (ASCIILiteral("")));

Please leave this one as it is. There is no construction from literal for empty strings, it is gonna assert.

I need to do some measurement to find the fastest way to initialize empty strings. I'll update the wiki as soon as I have the solution.

[Gyuyoung Kim]

Created attachment 161403 [details]
Patch

[Gyuyoung Kim]

Thank you for your review. I would like to fix the stuff you pointed out in new bug.

[Benjamin Poulain]

Comment on attachment 161403 [details]
Patch

Everything looks good.

[WebKit Review Bot]

Comment on attachment 161403 [details]
Patch

Clearing flags on attachment: 161403

Committed r127121: <http://trac.webkit.org/changeset/127121>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.