WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
Bug 95414
REGRESSION(
r127039
): It broke inspector/timeline/timeline-load.html fails on many platforms
https://bugs.webkit.org/show_bug.cgi?id=95414
Summary
REGRESSION(r127039): It broke inspector/timeline/timeline-load.html fails on ...
Roger Fong
Reported
2012-08-29 18:27:50 PDT
inspector/timeline/timeline-load.html:
Attachments
Add attachment
proposed patch, testcase, etc.
Roger Fong
Comment 1
2012-08-29 18:30:55 PDT
Test fails on Apple-Windows port :( any idea why?
Roger Fong
Comment 2
2012-08-29 18:38:37 PDT
diff: --- /home/buildbot/slave/win-release-tests/build/layout-test-results/inspector/timeline/timeline-load-expected.txt 2012-08-29 13:57:46.075447000 -0700 +++ /home/buildbot/slave/win-release-tests/build/layout-test-results/inspector/timeline/timeline-load-actual.txt 2012-08-29 13:57:46.074446900 -0700 @@ -9,6 +9,3 @@ Running: testIncompatible passed -Running: testMalformed -passed -
eustas.bug
Comment 3
2012-08-29 19:44:51 PDT
Last test case checks try-catch execution branch in TimelineModel.js: WebInspector.TimelineModelLoader.transferChunk Try to add "window.console.log('something');" around this code to see if it is the source of the problem.
Mikhail Pozdnyakov
Comment 4
2012-08-30 00:51:12 PDT
Have same problem on EFL port
Csaba Osztrogonác
Comment 5
2012-08-30 05:35:22 PDT
It isn't a win specific bug, it is a regression caused by
r127039
and affedted platforms are: Win, EFL, Qt Debug here is the Qt debug diff too: --- /home/webkitbuildbot/slaves/debug64bit/buildslave/qt-linux-64-debug/build/layout-test-results/inspector/timeline/timeline-load-expected.txt +++ /home/webkitbuildbot/slaves/debug64bit/buildslave/qt-linux-64-debug/build/layout-test-results/inspector/timeline/timeline-load-actual.txt @@ -6,9 +6,4 @@ Running: testNormal passed -Running: testIncompatible -passed -Running: testMalformed -passed -
Roger Fong
Comment 6
2012-08-30 14:14:34 PDT
the transferChunk code does not get called. In fact, from what I can tell, the last test isn't being run at all...
Roger Fong
Comment 7
2012-08-30 15:05:29 PDT
Also would like to note that it seems like the 3rd test in the test suite just isn't being run in the Windows case. If I switch the orders of the test cases, (malformed first, incompatible second), malformed test passes fine, incompatible test does not get run.
Roger Fong
Comment 8
2012-08-30 16:34:04 PDT
Upon further investigation I'm seeing strange behavior in InspectorTest.completeTest. In the first test, the code path makes it through the completeTest call and moves on to test the second test. The second test does not make it through completeTest and the third test does not get called. I can put the tests in any order and only the first 2 will ever be run. I would try to debug further... However, depending on where and what I log, the results change, which is madness. (Logging integers vs string literals changes things unexpectedly). I'm adding this test to the Windows skip list for now to get the bots greener.
Roger Fong
Comment 9
2012-08-30 16:43:30 PDT
It was fixed here this morning apparently...
http://trac.webkit.org/changeset/127135
by removing the completeTest call... Sigh, closing bug...
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug