Bug 95406 – Deploy ASCIILiteral in FontCacheWin.cpp

• Status: RESOLVED
• Resolution: LATER
• Component: New Bugs

[Adam Barth]

Deploy ASCIILiteral in FontCacheWin.cpp

[Adam Barth]

Created attachment 161365 [details]
Patch

[Benjamin Poulain]

Comment on attachment 161365 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=161365&action=review

> Source/WebCore/platform/graphics/win/FontCacheWin.cpp:330
> +        AtomicString(ASCIILiteral("Times New Roman")),
> +        AtomicString(ASCIILiteral("Microsoft Sans Serif")),
> +        AtomicString(ASCIILiteral("Tahoma")),
> +        AtomicString(ASCIILiteral("Lucida Sans Unicode")),
> +        AtomicString(ASCIILiteral("Arial"))

AtomicString should always use AtomicString::ConstructFromLiteral. (I should prevent AtomicString(ASCIILiteral) explicitly in AtomicString.h.)

The reason is I want to have compile time computation of the hash value in the future. When that template is done, we would not need to do any access to the characters at construction.

Sorry, I did not made that clear in my previous explanation, I did not anticipate this fast mass deployment of literal strings.

[Benjamin Poulain]

Hum, and the reason I want compile time hashing is that we spend quite some time in AtomicString when initializing WebKit.
We spend a lot of time loading memory we do not use immediately.

[Adam Barth]

Ok.  Would you be willing to add that information to the wiki?

[Benjamin Poulain]

(In reply to comment #4)
> Ok.  Would you be willing to add that information to the wiki?

I updated the WiKi.

I really want the implicit conversion to fail to compile, I'll fix that in https://bugs.webkit.org/show_bug.cgi?id=95413.