Bug 95395 – [Chromium] The CC button is not painted

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

[Victor Carbune]

The actual resource for the closed caption button needs to be used and painted.

[Victor Carbune]

Created attachment 161348 [details]
Fix

[Victor Carbune]

Created attachment 161434 [details]
Fixed minor issue

[Victor Carbune]

Comment on attachment 161348 [details]
Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=161348&action=review

> Source/WebCore/rendering/RenderMediaControlsChromium.cpp:374
>      case MediaShowClosedCaptionsButton:

Sorry, this was faulty as the switch case statement above were falling through. Fixed.

[Gyuyoung Kim]

Comment on attachment 161434 [details]
Fixed minor issue

Attachment 161434 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/13689633

[Victor Carbune]

(In reply to comment #4)
> (From update of attachment 161434 [details])
> Attachment 161434 [details] did not pass efl-ews (efl):
> Output: http://queues.webkit.org/results/13689633
Hmm, I don't think this break is caused by my patch.

[Eric Carlson]

(In reply to comment #5)
> (In reply to comment #4)
> > (From update of attachment 161434 [details] [details])
> > Attachment 161434 [details] [details] did not pass efl-ews (efl):
> > Output: http://queues.webkit.org/results/13689633
> Hmm, I don't think this break is caused by my patch.

I agree. Clearing cq-.

[WebKit Review Bot]

Comment on attachment 161434 [details]
Fixed minor issue

Clearing flags on attachment: 161434

Committed r127168: <http://trac.webkit.org/changeset/127168>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.