Bug 95393 - [chromium] setNeedsAnimate should not cause commitRequested to become true
Summary: [chromium] setNeedsAnimate should not cause commitRequested to become true
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nat Duca
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-08-29 15:45 PDT by Nat Duca
Modified: 2012-08-29 22:03 PDT (History)
5 users (show)

See Also:

Attachments
Patch (9.65 KB, patch)
2012-08-29 15:51 PDT, Nat Duca 		no flags Details | Formatted Diff | Diff
Patch for landing (9.61 KB, patch)
2012-08-29 16:11 PDT, Nat Duca 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nat Duca 2012-08-29 15:45:52 PDT 
[chromium] setNeedsAnimate should not cause commitRequested to become true
Comment 1 Nat Duca 2012-08-29 15:51:05 PDT 
Created attachment 161341 [details]
Patch
Comment 2 James Robinson 2012-08-29 15:56:50 PDT 
Comment on attachment 161341 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=161341&action=review

Cool

> Source/WebKit/chromium/ChangeLog:12
> +        (WTF):
> +        (CCLayerTreeHostTestSetNeedsAnimateShouldNotSetCommitRequested):
> +        (WTF::CCLayerTreeHostTestSetNeedsAnimateShouldNotSetCommitRequested::CCLayerTreeHostTestSetNeedsAnimateShouldNotSetCommitRequested):
> +        (WTF::TEST_F):

can you kill the WTF::? i'd fix prepare-ChangeLog to not do this but it's perl :\
Comment 3 Nat Duca 2012-08-29 16:11:09 PDT 
Created attachment 161347 [details]
Patch for landing
Comment 4 John Bates 2012-08-29 16:32:19 PDT 
nice. 1 frame down, 1 to go.
Comment 5 Nat Duca 2012-08-29 16:33:38 PDT 
baby steps!
Comment 6 WebKit Review Bot 2012-08-29 22:02:58 PDT 
Comment on attachment 161347 [details]
Patch for landing

Clearing flags on attachment: 161347

Committed r127099: <http://trac.webkit.org/changeset/127099>
Comment 7 WebKit Review Bot 2012-08-29 22:03:02 PDT 
All reviewed patches have been landed.  Closing bug.