WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
NEW
95390
rebaselining doesn't really work w/ multiple expectations files
https://bugs.webkit.org/show_bug.cgi?id=95390
Summary
rebaselining doesn't really work w/ multiple expectations files
Dirk Pranke
Reported
2012-08-29 15:39:03 PDT
If, for example, you mark a test for REBASELINE in platform/chromium/TestExpectations, and there is an overriding line in the skia_test_expectations.txt file, webkit-patch rebaseline-expectations will not see the line with the REBASELINE. After
r127057
, at least we'll log a warning that we didn't find a REBASELINE, but we should either be smarter about this (e.g., log a warning that tests are shadowing others) or stop using rebaseline-expectations altogether ;).
Attachments
Add attachment
proposed patch, testcase, etc.
Dirk Pranke
Comment 1
2013-02-12 15:31:58 PST
changing subject from "expectation overrides can cause REBASELINE modifiers to be missed" to "rebaselining doesn't really work w/ multiple expectations files"
Dirk Pranke
Comment 2
2013-06-24 13:09:02 PDT
I don't expect to work on this in the webkit.org repo in the foreseeable future, so I'm clearing the 'assigned_to' field in case someone cares to take a look.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug