WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
9538
Add support syntax-highlighted HTML source viewing
https://bugs.webkit.org/show_bug.cgi?id=9538
Summary
Add support syntax-highlighted HTML source viewing
Dave Hyatt
Reported
2006-06-21 23:18:29 PDT
This bug tracks my work on syntax highlighting of HTML source.
Attachments
Work in progress
(10.66 KB, patch)
2006-06-21 23:20 PDT
,
Dave Hyatt
no flags
Details
Formatted Diff
Diff
Patch that gets basic highlighting working.
(40.24 KB, patch)
2006-06-26 14:41 PDT
,
Dave Hyatt
hyatt
: review+
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Dave Hyatt
Comment 1
2006-06-21 23:20:55 PDT
Created
attachment 8958
[details]
Work in progress This is a snapshot of a work in progress. Adds new SPI to WebView for putting the view into a "view source mode". This will cause HTML and XML documents loaded in the view to display syntax-highlighted source by default. The plan is for XML to also do this when it detects it is unstyled and for CSS/JS to do it all the time. This patch also adds an HTML extension, a viewsource attribute, to iframes and frames, allowing Web site authors (or WebKit applications thate use frames) to show raw syntax-highlighted source as well.
Dave Hyatt
Comment 2
2006-06-26 14:41:57 PDT
Created
attachment 9053
[details]
Patch that gets basic highlighting working. This patch gets basic highlighting working. There are still many open issues, but this is a good first cut to land. Open issues include: (1) Loss of the whitespace in between tags and attributes and between attribute names/values. (2) Entities need to be preserved. (3) Scripts and styles don't work. (4) Comments need to be preserved (this should just be done always). (5) The DOCTYPE is lost. (6) The bogus "/" attribute for faux XHTML has to be sent through in view source mode and treated like it's part of a tag. ... and there are probably numerous other issues...
Dave Hyatt
Comment 3
2006-06-26 16:28:52 PDT
Comment on
attachment 9053
[details]
Patch that gets basic highlighting working. Darin reviewed this.
Timothy Hatcher
Comment 4
2006-06-27 18:46:13 PDT
Committed in
r15050
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug