Bug 95371 - [chromium] Make link highlighter use same node selection criteria as Chromium for Android.
Summary: [chromium] Make link highlighter use same node selection criteria as Chromium...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: W. James MacLean
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-08-29 13:27 PDT by W. James MacLean
Modified: 2012-08-31 17:32 PDT (History)
3 users (show)

See Also:

Attachments
Patch (29.62 KB, patch)
2012-08-29 13:29 PDT, W. James MacLean 		no flags Details | Formatted Diff | Diff
Patch (30.74 KB, patch)
2012-08-30 07:41 PDT, W. James MacLean 		no flags Details | Formatted Diff | Diff
Patch for landing (30.74 KB, patch)
2012-08-31 12:20 PDT, W. James MacLean 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description W. James MacLean 2012-08-29 13:27:05 PDT 
[chromium] Make link highlighter use same node selection criteria as Chromium for Android.
Comment 1 W. James MacLean 2012-08-29 13:29:14 PDT 
Created attachment 161298 [details]
Patch

This patch brings the choice of which node to highlight into alignment with Chromium for Android, for sake of consistency.
Comment 2 WebKit Review Bot 2012-08-29 23:17:38 PDT 
Comment on attachment 161298 [details]
Patch

Attachment 161298 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/13682558

New failing tests:
LinkHighlightTest.verifyWebViewImplIntegration
Comment 3 W. James MacLean 2012-08-30 07:41:17 PDT 
Created attachment 161466 [details]
Patch

Ooops, the .html resource file for the unit test was violating the auto z-index constraint ... fixed.
Comment 4 W. James MacLean 2012-08-31 12:20:07 PDT 
Created attachment 161750 [details]
Patch for landing
Comment 5 WebKit Review Bot 2012-08-31 17:32:49 PDT 
Comment on attachment 161750 [details]
Patch for landing

Clearing flags on attachment: 161750

Committed r127342: <http://trac.webkit.org/changeset/127342>
Comment 6 WebKit Review Bot 2012-08-31 17:32:52 PDT 
All reviewed patches have been landed.  Closing bug.