Bug 95369 - [CSS Exclusions] Exclusions tests should run without errors in standalone browser
Summary: [CSS Exclusions] Exclusions tests should run without errors in standalone bro...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Bear Travis
URL:
Keywords:
Depends on:
Blocks: 89256
  Show dependency tree / graph
 
Reported: 2012-08-29 12:56 PDT by Bear Travis
Modified: 2012-08-31 02:40 PDT (History)
2 users (show)

See Also:

Attachments
Fixing up the exclusions and shape-inside tests (10.03 KB, patch)
2012-08-29 13:18 PDT, Bear Travis 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Bear Travis 2012-08-29 12:56:49 PDT 
The exclusions tests currently enable/disable css exclusions through window.internals.settings, which is not available in standalone browsers.
Opening these pages in a standalone browser causes a reference error.
The tests should instead test for the existence of internals before attempting to reference it.
Comment 1 Bear Travis 2012-08-29 13:18:19 PDT 
Created attachment 161296 [details]
Fixing up the exclusions and shape-inside tests
Comment 2 WebKit Review Bot 2012-08-31 02:40:34 PDT 
Comment on attachment 161296 [details]
Fixing up the exclusions and shape-inside tests

Clearing flags on attachment: 161296

Committed r127241: <http://trac.webkit.org/changeset/127241>
Comment 3 WebKit Review Bot 2012-08-31 02:40:37 PDT 
All reviewed patches have been landed.  Closing bug.