WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
95363
[Chromium] Remove getRenderStyleForStrike from PlatformSupport
https://bugs.webkit.org/show_bug.cgi?id=95363
Summary
[Chromium] Remove getRenderStyleForStrike from PlatformSupport
Mark Pilgrim (Google)
Reported
2012-08-29 11:54:27 PDT
[Chromium] Remove getRenderStyleForStrike from PlatformSupport
Attachments
Patch
(19.91 KB, patch)
2012-08-29 11:55 PDT
,
Mark Pilgrim (Google)
no flags
Details
Formatted Diff
Diff
Patch
(19.86 KB, patch)
2012-08-29 13:38 PDT
,
Mark Pilgrim (Google)
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Mark Pilgrim (Google)
Comment 1
2012-08-29 11:55:16 PDT
Created
attachment 161278
[details]
Patch
WebKit Review Bot
Comment 2
2012-08-29 11:56:57 PDT
Please wait for approval from
abarth@webkit.org
,
dglazkov@chromium.org
,
fishd@chromium.org
,
jamesr@chromium.org
or
tkent@chromium.org
before submitting, as this patch contains changes to the Chromium public API. See also
https://trac.webkit.org/wiki/ChromiumWebKitAPI
.
WebKit Review Bot
Comment 3
2012-08-29 11:57:15 PDT
Attachment 161278
[details]
did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/Platform/ChangeLog', u'Source/Platf..." exit_code: 1 Source/WebCore/platform/graphics/harfbuzz/FontPlatformDataHarfBuzz.cpp:49: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 1 in 10 files If any of these errors are false positives, please file a bug against check-webkit-style.
Mark Pilgrim (Google)
Comment 4
2012-08-29 12:23:23 PDT
I fixed a bunch of existing style bugs as I was moving files around, but I actually don't know how to fix this last one.
Adam Barth
Comment 5
2012-08-29 12:30:50 PDT
Comment on
attachment 161278
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=161278&action=review
> Source/WebCore/platform/graphics/harfbuzz/FontPlatformDataHarfBuzz.cpp:321 > - PlatformSupport::getRenderStyleForStrike(m_family.data(), (((int)m_textSize) << 2) | (m_typeface->style() & 3), &m_style); > + getRenderStyleForStrike(m_family.data(), (((int)m_textSize) << 2) | (m_typeface->style() & 3), &m_style);
Now that this is a member function, we don't need to pass m_style as an argument. We can just access it from inside the function.
Adam Barth
Comment 6
2012-08-29 12:31:17 PDT
(In reply to
comment #4
)
> I fixed a bunch of existing style bugs as I was moving files around, but I actually don't know how to fix this last one.
Thanks for fixing most of them. This is definitely a style improvement. We can worry about this last warning another time.
Mark Pilgrim (Google)
Comment 7
2012-08-29 13:38:56 PDT
Created
attachment 161301
[details]
Patch
Mark Pilgrim (Google)
Comment 8
2012-08-29 13:39:22 PDT
Comment on
attachment 161301
[details]
Patch Nits addressed.
WebKit Review Bot
Comment 9
2012-08-29 13:45:38 PDT
Attachment 161301
[details]
did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/Platform/ChangeLog', u'Source/Platf..." exit_code: 1 Source/WebCore/platform/graphics/harfbuzz/FontPlatformDataHarfBuzz.cpp:49: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 1 in 10 files If any of these errors are false positives, please file a bug against check-webkit-style.
WebKit Review Bot
Comment 10
2012-09-05 12:03:46 PDT
Comment on
attachment 161301
[details]
Patch Clearing flags on attachment: 161301 Committed
r127623
: <
http://trac.webkit.org/changeset/127623
>
WebKit Review Bot
Comment 11
2012-09-05 12:03:51 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug