Bug 95363 – [Chromium] Remove getRenderStyleForStrike from PlatformSupport

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Misc.

[Mark Pilgrim (Google)]

[Chromium] Remove getRenderStyleForStrike from PlatformSupport

[Mark Pilgrim (Google)]

Created attachment 161278 [details]
Patch

[WebKit Review Bot]

Please wait for approval from [e-mail], [e-mail], [e-mail], [e-mail] or [e-mail] before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.

[WebKit Review Bot]

Attachment 161278 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/Platform/ChangeLog', u'Source/Platf..." exit_code: 1
Source/WebCore/platform/graphics/harfbuzz/FontPlatformDataHarfBuzz.cpp:49:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 1 in 10 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Mark Pilgrim (Google)]

I fixed a bunch of existing style bugs as I was moving files around, but I actually don't know how to fix this last one.

[Adam Barth]

Comment on attachment 161278 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=161278&action=review

> Source/WebCore/platform/graphics/harfbuzz/FontPlatformDataHarfBuzz.cpp:321
> -    PlatformSupport::getRenderStyleForStrike(m_family.data(), (((int)m_textSize) << 2) | (m_typeface->style() & 3), &m_style);
> +    getRenderStyleForStrike(m_family.data(), (((int)m_textSize) << 2) | (m_typeface->style() & 3), &m_style);

Now that this is a member function, we don't need to pass m_style as an argument.  We can just access it from inside the function.

[Adam Barth]

(In reply to comment #4)
> I fixed a bunch of existing style bugs as I was moving files around, but I actually don't know how to fix this last one.

Thanks for fixing most of them.  This is definitely a style improvement.  We can worry about this last warning another time.

[Mark Pilgrim (Google)]

Created attachment 161301 [details]
Patch

[Mark Pilgrim (Google)]

Comment on attachment 161301 [details]
Patch

Nits addressed.

[WebKit Review Bot]

Attachment 161301 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/Platform/ChangeLog', u'Source/Platf..." exit_code: 1
Source/WebCore/platform/graphics/harfbuzz/FontPlatformDataHarfBuzz.cpp:49:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 1 in 10 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[WebKit Review Bot]

Comment on attachment 161301 [details]
Patch

Clearing flags on attachment: 161301

Committed r127623: <http://trac.webkit.org/changeset/127623>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.