Bug 95353 - '\r's in test expectations files confused chromium-android layout test driver
Summary: '\r's in test expectations files confused chromium-android layout test driver
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Xianzhu Wang
URL:
Keywords:
Depends on:
Blocks: 93627
  Show dependency tree / graph
 
Reported: 2012-08-29 09:37 PDT by Xianzhu Wang
Modified: 2012-08-29 10:18 PDT (History)
3 users (show)

See Also:

Attachments
Patch (13.57 KB, patch)
2012-08-29 09:40 PDT, Xianzhu Wang 		no flags Details | Formatted Diff | Diff
=Fixed an unexpected change. Will land manually (13.43 KB, patch)
2012-08-29 10:17 PDT, Xianzhu Wang 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Xianzhu Wang 2012-08-29 09:37:37 PDT 
The following layout tests will output '\r's in the test results, which confuses chromium-android layout test driver because the new lines will be formalized when reading through 'adb shell':

fast/dom/Window/window-property-clearing.html
LayoutTests/fast/dom/simultaneouslyRegsiteredTimerFireOrder.html
Comment 1 Xianzhu Wang 2012-08-29 09:40:20 PDT 
Created attachment 161249 [details]
Patch
Comment 2 Xianzhu Wang 2012-08-29 09:47:28 PDT 
Seems that this kind of patch can't be applied in normal way.

I can also leave the expectation files unchanged, because at least on chromium-linux and chromium-android the line separators are ignored when comparing actual results to expectations, but I don't know how other platforms deal with line separators.
Comment 3 Adam Barth 2012-08-29 09:55:22 PDT 
We can also land it manually.
Comment 4 Adam Barth 2012-08-29 09:55:30 PDT 
Let me know what you prefer.
Comment 5 Xianzhu Wang 2012-08-29 09:56:43 PDT 
(In reply to comment #4)
> Let me know what you prefer.

I'd like to try CQ first. If it can't make it, I'll land it manually.
Comment 6 Adam Barth 2012-08-29 09:58:08 PDT 
Comment on attachment 161249 [details]
Patch

I doubt the cq will do any better than the style bot.
Comment 7 Xianzhu Wang 2012-08-29 10:02:21 PDT 
(In reply to comment #6)
> (From update of attachment 161249 [details])
> I doubt the cq will do any better than the style bot.

Agreed. As just found an unexpected change in the uploaded patch, I'll fix that try to submit it manually. Will be careful not to make the mistake as before :)
Comment 8 Xianzhu Wang 2012-08-29 10:17:56 PDT 
Created attachment 161260 [details]
=Fixed an unexpected change. Will land manually
Comment 9 Xianzhu Wang 2012-08-29 10:18:20 PDT 
Committed r127012: <http://trac.webkit.org/changeset/127012>