Bug 95352 – Web Inspector: Create JavaScriptSources based on network resources.

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Vsevolod Vlasov]

Introduced NetworkUISourceCodeProvider that is listening for ResourceTreeModel and creates UISourceCodes for them.
RawSourceCode does not create uiSourceCodes based on resource anymore (this is done by NetworkUISourceCodeProvider instead).
Moved script-uiSourceCode binding logic from RawSourceCode to ResourceScriptMapping.

[Vsevolod Vlasov]

Created attachment 161252 [details]
Patch

[Pavel Feldman]

Comment on attachment 161252 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=161252&action=review

> Source/WebCore/inspector/front-end/NetworkUISourceCodeProvider.js:78
> +            resource.request.addEventListener(WebInspector.NetworkRequest.Events.FinishedLoading, resourceFinished, this);

We should only add resources that are finished at the first place.

> Source/WebCore/inspector/front-end/NetworkUISourceCodeProvider.js:96
> +        if ((isDocument && this._uiSourceCodeForDocumentResource[resource.url]) || (!isDocument && this._uiSourceCodeForScriptResource[resource.url]))

Why do you distinguish those?

> Source/WebCore/inspector/front-end/RawSourceCode.js:38
> +WebInspector.RawSourceCode = function(script)

I don't see why we need this class now.

> Source/WebCore/inspector/front-end/UISourceCode.js:545
> +    setSourceMapping: function(sourceMapping)

You should remove sourceMapping from the constructor now.

[Vsevolod Vlasov]

Created attachment 161927 [details]
Patch

[Vsevolod Vlasov]

(In reply to comment #2)
> (From update of attachment 161252 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=161252&action=review
> 
> > Source/WebCore/inspector/front-end/NetworkUISourceCodeProvider.js:78
> > +            resource.request.addEventListener(WebInspector.NetworkRequest.Events.FinishedLoading, resourceFinished, this);
> 
> We should only add resources that are finished at the first place.
I am going to fix this in another patch.

> 
> > Source/WebCore/inspector/front-end/NetworkUISourceCodeProvider.js:96
> > +        if ((isDocument && this._uiSourceCodeForDocumentResource[resource.url]) || (!isDocument && this._uiSourceCodeForScriptResource[resource.url]))
> 
> Why do you distinguish those?
This is needed to correctly process "dynamic" scripts (dynamically inserted script elements).

> 
> > Source/WebCore/inspector/front-end/RawSourceCode.js:38
> > +WebInspector.RawSourceCode = function(script)
> 
> I don't see why we need this class now.
Removed.

> 
> > Source/WebCore/inspector/front-end/UISourceCode.js:545
> > +    setSourceMapping: function(sourceMapping)
> 
> You should remove sourceMapping from the constructor now.
Done

[WebKit Review Bot]

Comment on attachment 161927 [details]
Patch

Attachment 161927 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/13745145

[Pavel Feldman]

Comment on attachment 161927 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=161927&action=review

> Source/WebCore/inspector/front-end/NetworkUISourceCodeProvider.js:94
> +        if (this._uiSourceCodeForResource[resource.url])

You should check workspace for that.

> Source/WebCore/inspector/front-end/NetworkUISourceCodeProvider.js:132
> +        setTimeout(this._populate.bind(this), 0);

Please use ProjectDidReset

> Source/WebCore/inspector/front-end/ResourceScriptMapping.js:84
> +        script.setSourceMapping(this);

remove this.

> Source/WebCore/inspector/front-end/ResourceScriptMapping.js:109
> +            this._scriptIdForUISourceCode.put(uiSourceCode, scripts[i].scriptId);

Remove that?

[Vsevolod Vlasov]

Committed r127427: <http://trac.webkit.org/changeset/127427>

[WebKit Review Bot]

Re-opened since this is blocked by 95695

[Vsevolod Vlasov]

Committed r127454: <http://trac.webkit.org/changeset/127454>

[Csaba Osztrogonác]

(In reply to comment #9)
> Committed r127454: <http://trac.webkit.org/changeset/127454>

It broke a test. Could you check it? Here is the new bug report - https://bugs.webkit.org/show_bug.cgi?id=95729 (Because reopening
bugs is prohibited for me :) )