Bug 95345 - Web Inspector: Extract StylesSourceMapping from StylesUISourceCodeProvider.
Summary: Web Inspector: Extract StylesSourceMapping from StylesUISourceCodeProvider.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Vsevolod Vlasov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-08-29 08:15 PDT by Vsevolod Vlasov
Modified: 2012-08-29 08:38 PDT (History)
10 users (show)

See Also:

Attachments
Patch (11.03 KB, patch)
2012-08-29 08:17 PDT, Vsevolod Vlasov 		apavlov: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Vsevolod Vlasov 2012-08-29 08:15:18 PDT 
Patch to follow.

This is needed to prepare StylesUISourceCodeProvider for conversion into NetworkUISourceCodeProvider.
Comment 1 Vsevolod Vlasov 2012-08-29 08:17:52 PDT 
Created attachment 161230 [details]
Patch
Comment 2 Alexander Pavlov (apavlov) 2012-08-29 08:30:54 PDT 
Comment on attachment 161230 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=161230&action=review

One nit to be fixed before landing.

> Source/WebCore/inspector/front-end/StylesUISourceCodeProvider.js:75
> +        setTimeout(this._populate.bind(this), 0);

Please FIXME-comment this change, stating that this should be handled in a different manner (like a DidWorkspaceReset event or something)
Comment 3 Vsevolod Vlasov 2012-08-29 08:38:46 PDT 
Committed r127002: <http://trac.webkit.org/changeset/127002>