Bug 95338 - [BlackBerry] Eliminate build warnings
Summary: [BlackBerry] Eliminate build warnings
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Charles Wei
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-08-29 05:53 PDT by Charles Wei
Modified: 2012-08-30 05:36 PDT (History)
3 users (show)

See Also:

Attachments
Patch (3.42 KB, patch)
2012-08-29 05:58 PDT, Charles Wei 		no flags Details | Formatted Diff | Diff
Patch (2.53 KB, patch)
2012-08-30 00:47 PDT, Charles Wei 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Charles Wei 2012-08-29 05:53:59 PDT 
Comparison between signed and unsigned integers generates warnings.  Need to cast them to the same type to eliminate the warnings.
Comment 1 Charles Wei 2012-08-29 05:58:02 PDT 
Created attachment 161205 [details]
Patch
Comment 2 Kentaro Hara 2012-08-29 07:08:06 PDT 
Comment on attachment 161205 [details]
Patch

OK
Comment 3 Build Bot 2012-08-29 07:51:35 PDT 
Comment on attachment 161205 [details]
Patch

Attachment 161205 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/13682224
Comment 4 Kentaro Hara 2012-08-29 22:50:24 PDT 
Comment on attachment 161205 [details]
Patch

r-ing due to pizlo's comment here (https://bugs.webkit.org/show_bug.cgi?id=95418#c4). Sorry for the wrong review.
Comment 5 Filip Pizlo 2012-08-29 22:53:12 PDT 
(In reply to comment #4)
> (From update of attachment 161205 [details])
> r-ing due to pizlo's comment here (https://bugs.webkit.org/show_bug.cgi?id=95418#c4). Sorry for the wrong review.

No worries!  Signed comparisons in C++ are so annoying! ;-)
Comment 6 Charles Wei 2012-08-30 00:47:05 PDT 
Created attachment 161415 [details]
Patch
Comment 7 WebKit Review Bot 2012-08-30 05:36:48 PDT 
Comment on attachment 161415 [details]
Patch

Clearing flags on attachment: 161415

Committed r127128: <http://trac.webkit.org/changeset/127128>
Comment 8 WebKit Review Bot 2012-08-30 05:36:51 PDT 
All reviewed patches have been landed.  Closing bug.