Bug 95323 – Enable/disable composited scrolling based on overflow

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Sami Kyöstilä]

Enable/disable composited scrolling based on overflow

[Sami Kyöstilä]

Created attachment 161180 [details]
Patch

[Gyuyoung Kim]

Comment on attachment 161180 [details]
Patch

Attachment 161180 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/13682161

[Sami Kyöstilä]

Created attachment 161229 [details]
Patch

[Sami Kyostila]

Ping, anyone up for a review? This bug makes layer scrolling not work very reliably because the necessary layers aren't getting created.

Alternatively, we could remove the entire optimization and always respect -webkit-overflow-scrolling:touch (at a memory cost).

[Simon Fraser (smfr)]

Comment on attachment 161229 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=161229&action=review

> Source/WebCore/rendering/RenderLayer.cpp:2649
> +    if (renderer()->view() && compositor()->updateLayerCompositingState(this))
> +        compositor()->setCompositingLayersNeedRebuild();

I wish we could do partial tree updates :(

[WebKit Review Bot]

Comment on attachment 161229 [details]
Patch

Clearing flags on attachment: 161229

Committed r127620: <http://trac.webkit.org/changeset/127620>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

(In reply to comment #6)
> (From update of attachment 161229 [details])
> Clearing flags on attachment: 161229
> 
> Committed r127620: <http://trac.webkit.org/changeset/127620>

The test added in this revision has been failing on Mountain Lion. See <http://build.webkit.org/results/Apple%20MountainLion%20Release%20WK1%20(Tests)/r127620%20(613)/compositing/overflow/overflow-auto-with-touch-toggle-pretty-diff.html>.

(In reply to comment #8)
> (In reply to comment #6)
> > (From update of attachment 161229 [details] [details])
> > Clearing flags on attachment: 161229
> > 
> > Committed r127620: <http://trac.webkit.org/changeset/127620>
> 
> The test added in this revision has been failing on Mountain Lion. See <http://build.webkit.org/results/Apple%20MountainLion%20Release%20WK1%20(Tests)/r127620%20(613)/compositing/overflow/overflow-auto-with-touch-toggle-pretty-diff.html>.

The same test is also failing on Lion.

[James Robinson]

From the ChangeLog: "Note that this test will pass only if OVERFLOW_SCROLLING is enabled."  Since those apple mac ports don't set OVERFLOW_SCROLLING, they are expected to fail and should be marked as failing or have failing -expected.txt's checked in or whatever the apple-mac port does these days.

(In reply to comment #8)
> (In reply to comment #6)
> > (From update of attachment 161229 [details] [details])
> > Clearing flags on attachment: 161229
> > 
> > Committed r127620: <http://trac.webkit.org/changeset/127620>
> 
> The test added in this revision has been failing on Mountain Lion. See <http://build.webkit.org/results/Apple%20MountainLion%20Release%20WK1%20(Tests)/r127620%20(613)/compositing/overflow/overflow-auto-with-touch-toggle-pretty-diff.html>.

Landed Mac-specific expected results in <http://trac.webkit.org/r127645>.

[Simon Fraser (smfr)]

OVERFLOW_SCROLLING is a terrible name for this switch. We all have overflow scrolling! It should be ACCELERATED_OVERFLOW_SCROLLING or something.