Bug 95315 - Web Inspector: unsafe static_cast in RetainedDOMInfo::IsEquivalent
Summary: Web Inspector: unsafe static_cast in RetainedDOMInfo::IsEquivalent
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Yury Semikhatsky
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-08-29 02:08 PDT by Yury Semikhatsky
Modified: 2012-08-29 04:52 PDT (History)
15 users (show)

See Also:


Attachments
Patch (1.71 KB, patch)
2012-08-29 02:14 PDT, Yury Semikhatsky
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yury Semikhatsky 2012-08-29 02:08:59 PDT
Before casting v8::RetainedObjectInfo to WebCore::RetainedObjectInfo we should check if it is an instance of WebCore::RetainedObjectInfo as it may happen to be an instance of v8::internal::NativeGroupRetainedObjectInfo. This check can be accomplished by comparing labels of the two objects as the labels should be unique for retained groups.
Comment 1 Yury Semikhatsky 2012-08-29 02:14:28 PDT
Created attachment 161163 [details]
Patch
Comment 2 Ilya Tikhonovsky 2012-08-29 02:15:53 PDT
Comment on attachment 161163 [details]
Patch

lgtm
Comment 3 WebKit Review Bot 2012-08-29 04:52:56 PDT
Comment on attachment 161163 [details]
Patch

Clearing flags on attachment: 161163

Committed r126989: <http://trac.webkit.org/changeset/126989>
Comment 4 WebKit Review Bot 2012-08-29 04:52:59 PDT
All reviewed patches have been landed.  Closing bug.