RESOLVED FIXED95304
Improve string efficiency using StringBuilder and StringOperations 
https://bugs.webkit.org/show_bug.cgi?id=95304
Summary Improve string efficiency using StringBuilder and StringOperations
Adam Barth
Reported 2012-08-29 00:45:16 PDT
Improve string efficiency using StringBuilder and StringOperations
Attachments
Patch (8.65 KB, patch)
2012-08-29 00:46 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2012-08-29 00:46:17 PDT
Created attachment 161156 [details] Patch
Eric Seidel (no email)
Comment 2 2012-08-29 00:50:13 PDT
Comment on attachment 161156 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=161156&action=review Looks reasonable. AppleConvertedSpace is confusing. > Source/WebCore/css/CSSLineBoxContainValue.cpp:60 > + text.append(' '); We should rename .append(UChar) to .appendUChar() or similar so that my brain can think simple thoughts like "append is slow".... here it's obviously not. :)
Benjamin Poulain
Comment 3 2012-08-29 00:57:39 PDT
> We should rename .append(UChar) to .appendUChar() or similar so that my brain can think simple thoughts like "append is slow".... here it's obviously not. :) We should get rid of String::operator+=() and String::append() so that we can forget that "append is slow" :)
WebKit Review Bot
Comment 4 2012-08-29 04:16:25 PDT
Comment on attachment 161156 [details] Patch Clearing flags on attachment: 161156 Committed r126984: <http://trac.webkit.org/changeset/126984>
WebKit Review Bot
Comment 5 2012-08-29 04:16:29 PDT
All reviewed patches have been landed. Closing bug.
Darin Adler
Comment 6 2012-08-30 09:59:55 PDT
Looking at these patches and seeing how attractive people find +=, I’m wondering if we should add a += operator to StringBuilder.
Note You need to log in before you can comment on or make changes to this bug.