Bug 95291 – Deploy ASCIILiteral and StringBuilder in more places in WebCore

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Adam Barth]

Deploy ASCIILiteral and StringBuilder in more places in WebCore

[Adam Barth]

Created attachment 161140 [details]
Patch

[Benjamin Poulain]

Comment on attachment 161140 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=161140&action=review

Looks great!

How did you fix all the string? Manually or you have made a smart script?

I have a few comments but they are nitpicking.

> Source/WebCore/css/CSSCanvasValue.cpp:47
> +    result.appendLiteral(")");

append(')') is faster (it is mostly inline IIRC)

You can also use the string operators (operator+). If you do not have a branch, they do a better job than StringBuilder.

> Source/WebCore/css/CSSCrossfadeValue.cpp:96
> +    result.appendLiteral(")");

append(')')

> Source/WebCore/css/CSSPageRule.cpp:64
> +            text.appendLiteral(" ");

append(' ')

> Source/WebCore/css/CSSSelector.cpp:527
> +            str.append(prefix.string());

This is unfortunate. If that is useful elsewhere, we add StringBuilder::append(AtomicString).

> Source/WebCore/css/CSSSelector.cpp:631
> +            return tagHistoryText + " " + str.toString();

' '

> Source/WebCore/html/HTMLTitleElement.cpp:79
>      for (Node *n = firstChild(); n; n = n->nextSibling()) {
>          if (n->isTextNode())
> -            val += toText(n)->data();
> +            result.append(toText(n)->data());
>      }

Wow, that was pretty bad.

> Source/WebCore/platform/sql/SQLiteDatabase.cpp:96
> +    if (!SQLiteStatement(*this, ASCIILiteral("PRAGMA temp_store = MEMORY;")).executeCommand())

I have looked at our use of SQLiteStatement and I think we could make a malloc-free version for many operations.
But that would be stupid not to use ASCIILiteral in the meantime. :)

[Adam Barth]

> How did you fix all the string? Manually or you have made a smart script?

This isn't all of them.  I'm just greping around and fixing obvious stuff.

[Adam Barth]

Committed r126967: <http://trac.webkit.org/changeset/126967>

[Adam Barth]

I fixed all the above before landing.