Bug 95285 - [Tests] Add test case for right-to-left rendering of multiple fields time input UI
Summary: [Tests] Add test case for right-to-left rendering of multiple fields time inp...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: yosin
URL:
Keywords:
Depends on:
Blocks: 95168
  Show dependency tree / graph
 
Reported: 2012-08-28 21:56 PDT by yosin
Modified: 2012-08-29 21:04 PDT (History)
1 user (show)

See Also:

Attachments
Patch 1 (39.79 KB, patch)
2012-08-29 18:55 PDT, yosin 		no flags Details | Formatted Diff | Diff
Patch 2 (39.86 KB, patch)
2012-08-29 19:18 PDT, yosin 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description yosin 2012-08-28 21:56:05 PDT 
We should have a test case of RTL appearance of multiple fields time input UI.
Comment 1 yosin 2012-08-29 18:55:43 PDT 
Created attachment 161386 [details]
Patch 1
Comment 2 yosin 2012-08-29 18:56:37 PDT 
Comment on attachment 161386 [details]
Patch 1

Could you review this patch?
Thanks in advance.
Comment 3 Kent Tamura 2012-08-29 19:11:00 PDT 
Comment on attachment 161386 [details]
Patch 1

View in context: https://bugs.webkit.org/attachment.cgi?id=161386&action=review

> LayoutTests/fast/forms/time-multiple-fields/time-multiple-fields-appearance-basic.html:10
> +    <li>RTL <input type="time" step="1" value="12:34:56"></li>

This is not RTL.
Comment 4 yosin 2012-08-29 19:18:34 PDT 
Created attachment 161389 [details]
Patch 2
Comment 5 yosin 2012-08-29 19:19:55 PDT 
Comment on attachment 161389 [details]
Patch 2

Could you review this patch?
Thanks in advance.

= Changes since the last review =
* Add 'dir="rtl"' to test case.
* Update expectation PNG and TXT
Comment 6 Kent Tamura 2012-08-29 20:05:18 PDT 
Comment on attachment 161389 [details]
Patch 2

ok
Comment 7 yosin 2012-08-29 20:22:14 PDT 
Comment on attachment 161389 [details]
Patch 2

Clearing flags on attachment: 161389

Committed r127089: <http://trac.webkit.org/changeset/127089>
Comment 8 yosin 2012-08-29 20:22:18 PDT 
All reviewed patches have been landed.  Closing bug.