Bug 95280 - [Forms] Rename DateTimeFieldElement::FieldEventHandler to FieldOwner
Summary: [Forms] Rename DateTimeFieldElement::FieldEventHandler to FieldOwner
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Forms (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: yosin
URL:
Keywords:
Depends on:
Blocks: 95168
  Show dependency tree / graph
 
Reported: 2012-08-28 21:07 PDT by yosin
Modified: 2012-08-29 19:24 PDT (History)
3 users (show)

See Also:

Attachments
Patch 1 (20.34 KB, patch)
2012-08-28 21:20 PDT, yosin 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description yosin 2012-08-28 21:07:33 PDT 
For changing Shift+Tab behavior of multiple field time input UI, DateTimeFieldElement needs to ask field owner for moving focus around field, e.g. focusOnNextFIeld(), and focusOnPreviousField(). These new functions aren't fit for in FieldEventHandler. To make class name matched to its functionality, we would like to rename FieldEventHandler to FieldOwner.

See https://bugs.webkit.org/attachment.cgi?id=161128&action=prettypatch for usage of DateTimeFieldElement::FieldOwner class.
Comment 1 yosin 2012-08-28 21:20:34 PDT 
Created attachment 161130 [details]
Patch 1
Comment 2 yosin 2012-08-28 21:21:14 PDT 
Comment on attachment 161130 [details]
Patch 1

Could you review this patch?
Thanks in advance.
Comment 3 Kent Tamura 2012-08-29 17:57:50 PDT 
(In reply to comment #2)
> (From update of attachment 161130 [details])
> Could you review this patch?

Then, please set r? flag.
Comment 4 yosin 2012-08-29 18:39:26 PDT 
Comment on attachment 161130 [details]
Patch 1

Could you review this patch?
Thanks in advance.

P.S. I forgot to set "r?".... orz
Comment 5 Kent Tamura 2012-08-29 19:08:23 PDT 
Comment on attachment 161130 [details]
Patch 1

ok
Comment 6 yosin 2012-08-29 19:24:14 PDT 
Comment on attachment 161130 [details]
Patch 1

Clearing flags on attachment: 161130

Committed r127085: <http://trac.webkit.org/changeset/127085>
Comment 7 yosin 2012-08-29 19:24:17 PDT 
All reviewed patches have been landed.  Closing bug.