Bug 95279 - [Forms] Make HTMLInputElement::blur()/focus() override-able by input type
Summary: [Forms] Make HTMLInputElement::blur()/focus() override-able by input type
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Forms (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: yosin
URL:
Keywords:
Depends on: 95298
Blocks: 95168
  Show dependency tree / graph
 
Reported: 2012-08-28 20:44 PDT by yosin
Modified: 2012-08-29 00:12 PDT (History)
5 users (show)

See Also:

Attachments
Patch 1 (4.59 KB, patch)
2012-08-28 20:53 PDT, yosin 		no flags Details | Formatted Diff | Diff
Patch 2 (4.71 KB, patch)
2012-08-28 20:56 PDT, yosin 		no flags Details | Formatted Diff | Diff
Patch 3 (4.68 KB, patch)
2012-08-28 20:58 PDT, yosin 		no flags Details | Formatted Diff | Diff
Patch 4 (4.44 KB, patch)
2012-08-28 23:42 PDT, yosin 		no flags Details | Formatted Diff | Diff
Patch 5 (5.02 KB, patch)
2012-08-29 00:10 PDT, yosin 		no flags Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description yosin 2012-08-28 20:44:34 PDT 
This patch is part of Shift+Tab focus navigation fix for multiple time input UI.

On multiple fields time input UI, we would like to make focus() and blur() JavaScript methods to move focus into/out to field inside shadow DOM tree. To do this, we would like make HTMLInputElement::focus()/blur() override-able bu InputType class.
Comment 1 yosin 2012-08-28 20:53:42 PDT 
Created attachment 161124 [details]
Patch 1
Comment 2 yosin 2012-08-28 20:56:17 PDT 
Created attachment 161125 [details]
Patch 2
Comment 3 yosin 2012-08-28 20:58:08 PDT 
Created attachment 161127 [details]
Patch 3
Comment 4 yosin 2012-08-28 20:58:39 PDT 
Comment on attachment 161127 [details]
Patch 3

Could you review this patch?
Thanks in advance.
Comment 5 Hajime Morrita 2012-08-28 23:04:03 PDT 
Comment on attachment 161127 [details]
Patch 3

View in context: https://bugs.webkit.org/attachment.cgi?id=161127&action=review

> Source/WebCore/ChangeLog:9
> +        override-able by InputType class if ENABLE_INPUT_TYPE_TIME_MULTIPLE_FIELDS

I don't think we need to hide these code blocks under ENABLE_INPUT_TYPE_TIME_MULTIPLE_FIELDS.
Overriding method conditionally can cause tricky problem.
Comment 6 yosin 2012-08-28 23:42:43 PDT 
Created attachment 161146 [details]
Patch 4
Comment 7 yosin 2012-08-28 23:44:38 PDT 
Comment on attachment 161146 [details]
Patch 4

Clearing flags on attachment: 161146

Committed r126963: <http://trac.webkit.org/changeset/126963>
Comment 8 yosin 2012-08-28 23:44:43 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 9 WebKit Review Bot 2012-08-28 23:59:22 PDT 
Re-opened since this is blocked by 95298
Comment 10 yosin 2012-08-29 00:10:58 PDT 
Created attachment 161152 [details]
Patch 5
Comment 11 yosin 2012-08-29 00:12:23 PDT 
Comment on attachment 161152 [details]
Patch 5

Clearing flags on attachment: 161152

Committed r126966: <http://trac.webkit.org/changeset/126966>
Comment 12 yosin 2012-08-29 00:12:28 PDT 
All reviewed patches have been landed.  Closing bug.