Bug 95277 - JSC: adding support for adding LLInt opcode extensions
Summary: JSC: adding support for adding LLInt opcode extensions
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-08-28 18:36 PDT by Mark Lam
Modified: 2012-08-28 20:57 PDT (History)
3 users (show)

See Also:


Attachments
Fix. (7.88 KB, patch)
2012-08-28 18:46 PDT, Mark Lam
no flags Details | Formatted Diff | Diff
One more time after svn up. (7.88 KB, patch)
2012-08-28 18:49 PDT, Mark Lam
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2012-08-28 18:36:00 PDT
Adding support for adding LLInt opcode extensions.  This will be needed by the LLInt C loop interpreter later.  Currently, this change should have no effect on the behavior of existing code.
Comment 1 Mark Lam 2012-08-28 18:46:08 PDT
Created attachment 161113 [details]
Fix.
Comment 2 Mark Lam 2012-08-28 18:49:49 PDT
Created attachment 161114 [details]
One more time after svn up.
Comment 3 Geoffrey Garen 2012-08-28 19:11:25 PDT
Comment on attachment 161114 [details]
One more time after svn up.

I like this idea of distinguishing between core opcodes emitted by the compiler and extension / optimization opcodes used by the engine. We could take this even further by separating out opcodes like op_get_by_id_* and op_put_by_id_*.
Comment 4 WebKit Review Bot 2012-08-28 19:24:30 PDT
Comment on attachment 161114 [details]
One more time after svn up.

Rejecting attachment 161114 [details] from review queue.

ggaren@apple.com does not have reviewer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py.

- If you do not have reviewer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have reviewer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your reviewer rights.
Comment 5 WebKit Review Bot 2012-08-28 19:27:00 PDT
Comment on attachment 161114 [details]
One more time after svn up.

Rejecting attachment 161114 [details] from commit-queue.

ggaren@apple.com does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py.

- If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your committer rights.
Comment 6 Geoffrey Garen 2012-08-28 20:16:36 PDT
Comment on attachment 161114 [details]
One more time after svn up.

Trying cq+ again.
Comment 7 WebKit Review Bot 2012-08-28 20:57:30 PDT
Comment on attachment 161114 [details]
One more time after svn up.

Clearing flags on attachment: 161114

Committed r126955: <http://trac.webkit.org/changeset/126955>
Comment 8 WebKit Review Bot 2012-08-28 20:57:33 PDT
All reviewed patches have been landed.  Closing bug.