WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
NEW
95270
webkit-patch rebaseline-expectations touches files too many times
https://bugs.webkit.org/show_bug.cgi?id=95270
Summary
webkit-patch rebaseline-expectations touches files too many times
Dirk Pranke
Reported
2012-08-28 17:48:05 PDT
We are reading and writing each TestExpectations file multiple times regardless of whether there's actually any REBASELINE lines in the file or we actually did anything. A partial fix would be to only iterate over the set of unique expectations_dict() values, rather that all of the port names. Another would be to skip rewriting the file if get_rebaselining_failures() returned an empty set.
Attachments
Add attachment
proposed patch, testcase, etc.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug