Bug 95270 - webkit-patch rebaseline-expectations touches files too many times
Summary: webkit-patch rebaseline-expectations touches files too many times
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-08-28 17:48 PDT by Dirk Pranke
Modified: 2017-07-18 08:29 PDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dirk Pranke 2012-08-28 17:48:05 PDT 
We are reading and writing each TestExpectations file multiple times regardless of whether there's actually any REBASELINE lines in the file or we actually did anything. 

A partial fix would be to only iterate over the set of unique expectations_dict() values, rather that all of the port names. Another would be to skip rewriting the file if get_rebaselining_failures() returned an empty set.