crypto.getRandomValues should throw an exception when given a big array
Created attachment 161101 [details] Patch
Comment on attachment 161101 [details] Patch OK.
Comment on attachment 161101 [details] Patch Rejecting attachment 161101 [details] from review queue. eric@webkit.org does not have reviewer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py. - If you do not have reviewer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have reviewer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your reviewer rights.
Comment on attachment 161101 [details] Patch Rejecting attachment 161101 [details] from commit-queue. eric@webkit.org does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py. - If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your committer rights.
Comment on attachment 161101 [details] Patch Clearing flags on attachment: 161101 Committed r126953: <http://trac.webkit.org/changeset/126953>
All reviewed patches have been landed. Closing bug.
Comment on attachment 161101 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=161101&action=review > LayoutTests/security/crypto-random-values-limits.html:20 > + var largeArray = new Uint8Array(66000); If the limit is specified in the spec, then I’d suggest that the test case also tries both the largest size that is allowed and the smallest size that is not allowed.
(In reply to comment #7) > (From update of attachment 161101 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=161101&action=review > > > LayoutTests/security/crypto-random-values-limits.html:20 > > + var largeArray = new Uint8Array(66000); > > If the limit is specified in the spec, then I’d suggest that the test case also tries both the largest size that is allowed and the smallest size that is not allowed. That's a good idea. The limit is in the spec.