RESOLVED INVALID Bug 95266
check-webkit-style gets confused when a function returns PassRefPtr 
https://bugs.webkit.org/show_bug.cgi?id=95266
Summary check-webkit-style gets confused when a function returns PassRefPtr
Alexandru Chiculita
Reported 2012-08-28 16:59:32 PDT
The following line confuses the style checker. I assume this is related to the patch context, as I cannot reproduce the issue without that specific patch. PassRefPtr<CustomFilterParameter> StyleResolver::parseCustomFilterTransformParameter(const String& name, CSSValueList* values) https://bugs.webkit.org/show_bug.cgi?id=71401#c8 Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/css3..." exit_code: 1 Source/WebCore/css/StyleResolver.cpp:5264: Local variables should never be PassRefPtr (see http://webkit.org/coding/RefPtr.html). [readability/pass_ptr] [5] Source/WebCore/css/StyleResolver.cpp:5273: Local variables should never be PassRefPtr (see http://webkit.org/coding/RefPtr.html). [readability/pass_ptr] [5] Total errors found: 2 in 20 files
Attachments
Add attachment proposed patch, testcase, etc.
Brian Burg
Comment 1 2015-01-06 14:42:07 PST
PassRefPtr is deprecated, and this style check will be removed soon.
Note You need to log in before you can comment on or make changes to this bug.