Bug 95266 - check-webkit-style gets confused when a function returns PassRefPtr
Summary: check-webkit-style gets confused when a function returns PassRefPtr
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-08-28 16:59 PDT by Alexandru Chiculita
Modified: 2015-01-06 14:42 PST (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexandru Chiculita 2012-08-28 16:59:32 PDT 
The following line confuses the style checker. I assume this is related to the patch context, as I cannot reproduce the issue without that specific patch.

PassRefPtr<CustomFilterParameter> StyleResolver::parseCustomFilterTransformParameter(const String& name, CSSValueList* values)

https://bugs.webkit.org/show_bug.cgi?id=71401#c8

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/css3..." exit_code: 1
Source/WebCore/css/StyleResolver.cpp:5264:  Local variables should never be PassRefPtr (see http://webkit.org/coding/RefPtr.html).  [readability/pass_ptr] [5]
Source/WebCore/css/StyleResolver.cpp:5273:  Local variables should never be PassRefPtr (see http://webkit.org/coding/RefPtr.html).  [readability/pass_ptr] [5]
Total errors found: 2 in 20 files
Comment 1 Brian Burg 2015-01-06 14:42:07 PST 
PassRefPtr is deprecated, and this style check will be removed soon.